Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move locales into their specific modules #2726

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jul 3, 2024

Moves locales into their specific modules instead of in a global/root locales folder.


Note: This is currently failing because it it waiting on unravelling /services/development a little more. I have a PR for that ready to go, but I'm trying to avoid clashing with other open PRs.

edit: See #2729 which this probably requires <-- this has been merged and this is now rebased

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 565d636
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/669fb9554fd9210008048946
😎 Deploy Preview https://deploy-preview-2726--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johncowen johncowen marked this pull request as ready for review July 9, 2024 16:58
@johncowen johncowen requested a review from a team as a code owner July 9, 2024 16:58
@johncowen johncowen self-assigned this Jul 10, 2024
@johncowen johncowen added this to the 2.9.x milestone Jul 12, 2024
@johncowen johncowen merged commit fedc455 into kumahq:master Jul 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants