feat(zones): move KDSSubscriptions to use a table/summary #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
force-pushed
the
feature/kds-panel
branch
2 times, most recently
from
e434257
to
2ce1472
Compare
johncowen
force-pushed
the
feature/kds-panel
branch
2 times, most recently
from
97d05a1
to
ad69dd6
Compare
I figured we probably don't want to show the YAML, its not like you'd want to use it for anything. If that incorrect we can always add as a follow up. |
johncowen
force-pushed
the
feature/kds-panel
branch
2 times, most recently
from
f3c2558
to
c895162
Compare
johncowen
force-pushed
the
feature/kds-panel
branch
from
c895162
to
e20326a
Compare
johncowen
force-pushed
the
feature/kds-panel
branch
2 times, most recently
from
c0069cc
to
7874509
Compare
lahabana
reviewed
Jul 30, 2024
lahabana
reviewed
Jul 30, 2024
lahabana
reviewed
Jul 30, 2024
lahabana
reviewed
Jul 30, 2024
lahabana
reviewed
Jul 30, 2024
johncowen
force-pushed
the
feature/kds-panel
branch
2 times, most recently
from
5eafdc3
to
66ef964
Compare
|
K this one has had a few alterations after a first round of reviews, good to go again now 👍 |
lahabana
reviewed
Aug 1, 2024
johncowen
commented
Aug 1, 2024
johncowen
commented
Aug 1, 2024
src/app/subscriptions/views/SubscriptionSummaryOverviewView.vue
Outdated
Show resolved
Hide resolved
johncowen
force-pushed
the
feature/kds-panel
branch
from
76ac0a2
to
06e4fca
Compare
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
feature/kds-panel
branch
from
06e4fca
to
77aaf2b
Compare
|
LGTM do we have issues to cover the same work for dataplane and zone proxies? If not can we open them and milestone them for 2.10 please? |
This was referenced Sep 12, 2024
lahabana
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Zone Subscriptions only to use a table/summary view/interaction.
We decided that there would be far more space to show things if we used our common table/summary panel pattern instead of the accordion where there is very little space to show things:
See:
Questions:1. Do we want to show the Subscription YAML, the Subscription JSON config, or both?2. If we want to show both, should we add a separate[YAML]tab or use theStructured/YAMLdropdown?Note:
I'm guessing we'll want the same layout for DPP subscriptions, I plan to do this as a follow up and there will some changes made on top of here to make the panel work in both places.
Closes #2704