Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/append faq #48

Merged
merged 14 commits into from
Jan 19, 2021
Merged

Conversation

volkansahn
Copy link
Contributor

@volkansahn volkansahn commented Jan 18, 2021

I think we still can merge Issue 21 and Issue 45

I add some new FAQ about how to make PR.

Preview : https://raw.githack.com/volkansahn/open-source/feature/append-faq/en_ID/#!pages/faq.md

Copy link
Contributor

@empeje empeje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2021-01-18 at 21 23 12

en_ID/pages/faq.md Outdated Show resolved Hide resolved
en_ID/pages/faq.md Outdated Show resolved Hide resolved
en_ID/pages/faq.md Show resolved Hide resolved
New FAQ for Github
New FAQ for Github
New FAQ about Github
New FAQ about Github
New FAQ for Github
* Github automatically ask you if you want to create PR with your changes.
* If you cant see automatic PR from github;
* Click branch drop down list
![][branchlist-image]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more challenge, the image displayed too big on my side, it doesn't fit with its container.

hint: you can use plain HTML to display images.

Screen Shot 2021-01-19 at 10 04 23

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check it again ?

New FAQ for Github
Copy link
Contributor

@empeje empeje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done 🎉

@empeje empeje merged commit 209bf74 into kulkultech:gh-pages Jan 19, 2021
@empeje empeje mentioned this pull request Jan 19, 2021
@volkansahn volkansahn deleted the feature/append-faq branch January 19, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants