Fixed error image on load in FAQ #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By trying different case to hopefully get a correct solution.
AlfredPros
changed the title
|
looks good, now I didn't see the error getting image url in console. please create PR. |
|
It is not neccessary @AlfredPros, this is by design the URL is relative. |
|
Closing the issue for inactivity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve: #147
Preview link: https://raw.githack.com/AlfredPros/open-source/faq-fix-image/index.html
Now, it no longer have 404 error when loading the webpage. On other hand, the webpage loads faster.
I mainly switched the usage of relative directory into fixed directory because the webpage doesn't handle relative directory too well.