add menu viewcontroller safearea support #148
Open
+136
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enefry
commented
Nov 8, 2023
enefry
commented
- add safe area support for menu viewcontroller
- update to ios 11
* 'master' of https://github.com/kukushi/SideMenu: chore: bump version to 2.0.10 Bump activesupport from 7.0.4.3 to 7.0.7.2
2. update example menu viewcontroller using safearea
2. update readme to ios 11.0 3. update podspec to ios 11.0
|
Hi, @enefry , your PR looks good, would you mind removing the irrelevant part then I can merge it. |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.