Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close host cluster proxy watch when member clustr watch closed #341

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

wy-lucky
Copy link
Collaborator

No description provided.

@wy-lucky wy-lucky changed the title fix: close host cluster proxy watch when member clustr watch close fix: close host cluster proxy watch when member clustr watch closed Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 33.63%. Comparing base (cb49360) to head (2234da6).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../registry/hpaaggregator/aggregation/forward/pod.go 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   33.91%   33.63%   -0.28%     
==========================================
  Files         156      156              
  Lines       14730    18048    +3318     
==========================================
+ Hits         4995     6071    +1076     
- Misses       9214    11456    +2242     
  Partials      521      521              
Flag Coverage Δ
unittests 33.63% <0.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlihanbo mrlihanbo self-requested a review November 27, 2024 03:28
@Poor12 Poor12 disabled auto-merge November 27, 2024 03:36
@mrlihanbo mrlihanbo merged commit eea8b07 into kubewharf:main Nov 27, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants