Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support reclaimed numa binding test #709

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

@luomingmeng luomingmeng changed the title Dev/support reclaimed numa binding test support reclaimed numa binding test Oct 22, 2024
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-numa-binding-test branch 3 times, most recently from 3a6abe4 to a613553 Compare October 23, 2024 08:02
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 56.52791% with 919 lines in your changes missing coverage. Please review.

Project coverage is 55.94%. Comparing base (19aa317) to head (0d1210f).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...isor/plugin/qosaware/reporter/headroom_reporter.go 14.15% 89 Missing and 2 partials ⚠️
...memory/dynamicpolicy/policy_allocation_handlers.go 50.95% 65 Missing and 12 partials ⚠️
...ugins/memory/dynamicpolicy/policy_hint_handlers.go 66.36% 62 Missing and 12 partials ⚠️
...qrm-plugins/cpu/dynamicpolicy/cpuadvisor/cpu.pb.go 3.94% 70 Missing and 3 partials ⚠️
...lugins/cpu/dynamicpolicy/policy_advisor_handler.go 55.46% 42 Missing and 15 partials ⚠️
...ns/cpu/dynamicpolicy/policy_allocation_handlers.go 60.28% 43 Missing and 13 partials ⚠️
...olicy/cpueviction/strategy/pressure_suppression.go 48.10% 36 Missing and 5 partials ⚠️
...pu/assembler/headroomassembler/assembler_common.go 58.33% 35 Missing and 5 partials ⚠️
...-plugins/cpu/dynamicpolicy/policy_hint_handlers.go 82.91% 26 Missing and 8 partials ⚠️
...in/qosaware/resource/memory/plugin/memory_guard.go 57.50% 32 Missing and 2 partials ⚠️
... and 35 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   56.04%   55.94%   -0.10%     
==========================================
  Files         594      596       +2     
  Lines       67830    69440    +1610     
==========================================
+ Hits        38012    38845     +833     
- Misses      25771    26463     +692     
- Partials     4047     4132      +85     
Flag Coverage Δ
unittest 55.94% <56.52%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-numa-binding-test branch 4 times, most recently from b581d57 to 90820ee Compare October 29, 2024 09:26
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-numa-binding-test branch 11 times, most recently from dd917d7 to 7cf360b Compare November 5, 2024 08:08
…n state for shared or dedicated numa binding without exclusive pods
…memory plugin for reclaim pods that are actually bound to specific NUMA nodes
…y limit only consider NUMAs without actual numa-binding pod
… both applyBlocks and applyPoolsAndIsolatedInfo
@luomingmeng luomingmeng force-pushed the dev/support-reclaimed-numa-binding-test branch from 7cf360b to 0d1210f Compare November 25, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants