Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip pod when getTopologyHints in ORM #620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WangZzzhe
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Skip pods which are not system cores but owned by daemonSet when getTopologyHints in ORM.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@WangZzzhe WangZzzhe added bug Something isn't working workflow/need-review review: test succeeded, need to review labels Jun 11, 2024
@WangZzzhe WangZzzhe self-assigned this Jun 11, 2024
@WangZzzhe WangZzzhe requested a review from caohe as a code owner June 11, 2024 11:39
@WangZzzhe WangZzzhe force-pushed the fix/getTopologyHints-skip-pod branch from 7f39056 to 02597ce Compare June 11, 2024 11:54
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.19%. Comparing base (5e1814b) to head (02597ce).
Report is 13 commits behind head on main.

Files Patch % Lines
pkg/agent/orm/manager.go 70.58% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #620      +/-   ##
==========================================
+ Coverage   56.14%   56.19%   +0.04%     
==========================================
  Files         535      543       +8     
  Lines       49865    50387     +522     
==========================================
+ Hits        27997    28315     +318     
- Misses      18307    18474     +167     
- Partials     3561     3598      +37     
Flag Coverage Δ
unittest 56.19% <73.68%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working workflow/need-review review: test succeeded, need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant