Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong Kubernetes kinds. #62

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix: wrong Kubernetes kinds. #62

merged 1 commit into from
Jan 12, 2024

Conversation

jvanz
Copy link
Member

@jvanz jvanz commented Jan 11, 2024

Description

The SDK is using the wrong kind types to extract and update PodSpec in the different Kubernetes kinds supported. This commit fixes the kind names.

@jvanz
fix: wrong Kubernetes kinds.
c4748c7 
The SDK is using the wrong kind types to extract and update PodSpec in
the different Kubernetes kinds supported. This commit fixes the kind
names.

Signed-off-by: José Guilherme Vanz <[email protected]>
@jvanz jvanz added the kind/bug label Jan 11, 2024
@jvanz jvanz self-assigned this Jan 11, 2024
@jvanz jvanz requested a review from a team as a code owner January 11, 2024 12:40
@jvanz jvanz mentioned this pull request Jan 11, 2024
Merged
viccuad
viccuad approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@viccuad viccuad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I wonder if this may have been misused in some policy already, but I guess we will find out when we bump the sdk there.

@jvanz
Copy link
Member Author

jvanz commented Jan 12, 2024

LGTM! I wonder if this may have been misused in some policy already, but I guess we will find out when we bump the sdk there.

As far as I know, there is no policies using this functions. At least, none maintained by the Kubewarden team

@flavio
Copy link
Member

flavio commented Jan 12, 2024

This is fine, but we should look for group and version too. Otherwise something like argocd.io/v1/Deployment would be mistaken as apps/v1/Deployment

@jvanz can you please file an issue about that? This can be fixed with another PR

@jvanz
Copy link
Member Author

jvanz commented Jan 12, 2024 •
edited
Loading

This is fine, but we should look for group and version too. Otherwise something like argocd.io/v1/Deployment would be mistaken as apps/v1/Deployment

@jvanz can you please file an issue about that? This can be fixed with another PR

@flavio I've opened two issues to address this in the go and rust SDKs.

#63
kubewarden/policy-sdk-rust#126

@jvanz jvanz merged commit 40bb2eb into kubewarden:main Jan 12, 2024
5 checks passed
@jvanz jvanz deleted the fix-kinds branch January 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viccuad viccuad viccuad approved these changes

@flavio flavio flavio approved these changes

Assignees

@jvanz jvanz

Labels
kind/bug
Projects
Kubewarden
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvanz @flavio @viccuad