Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update module org_golang_google_grpc to v1.56.3 [security] (main) #1160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

redhat-renovate-bot
Copy link
Collaborator

@redhat-renovate-bot redhat-renovate-bot commented Dec 4, 2024

This PR contains the following updates:

Package Type Update Change
org_golang_google_grpc go_repository minor v1.49.0 -> v1.56.3

gRPC-Go HTTP/2 Rapid Reset vulnerability

BIT-apisix-2023-44487 / BIT-aspnet-core-2023-44487 / BIT-contour-2023-44487 / BIT-dotnet-2023-44487 / BIT-dotnet-sdk-2023-44487 / BIT-envoy-2023-44487 / BIT-golang-2023-44487 / BIT-jenkins-2023-44487 / BIT-kong-2023-44487 / BIT-nginx-2023-44487 / BIT-nginx-ingress-controller-2023-44487 / BIT-node-2023-44487 / BIT-node-min-2023-44487 / BIT-solr-2023-44487 / BIT-tomcat-2023-44487 / BIT-varnish-2023-44487 / CGA-4mmr-qwxr-f88g / CGA-5jp5-95p2-jw83 / CGA-5v4r-558c-254r / CGA-9w4r-68hh-64j5 / CGA-m49h-wjp5-j434 / CGA-mp43-q6p3-96v2 / CVE-2023-44487 / GHSA-m425-mq94-257g / GHSA-qppj-fm5r-hxr3 / GO-2023-2153

More information

Details

Impact

In affected releases of gRPC-Go, it is possible for an attacker to send HTTP/2 requests, cancel them, and send subsequent requests, which is valid by the HTTP/2 protocol, but would cause the gRPC-Go server to launch more concurrent method handlers than the configured maximum stream limit.

Patches

This vulnerability was addressed by #​6703 and has been included in patch releases: 1.56.3, 1.57.1, 1.58.3. It is also included in the latest release, 1.59.0.

Along with applying the patch, users should also ensure they are using the grpc.MaxConcurrentStreams server option to apply a limit to the server's resources used for any single connection.

Workarounds

None.

References

#​6703

Severity

  • CVSS Score: 7.5 / 10 (High)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


Denial of service from HTTP/2 Rapid Reset in google.golang.org/grpc

BIT-apisix-2023-44487 / BIT-aspnet-core-2023-44487 / BIT-contour-2023-44487 / BIT-dotnet-2023-44487 / BIT-dotnet-sdk-2023-44487 / BIT-envoy-2023-44487 / BIT-golang-2023-44487 / BIT-jenkins-2023-44487 / BIT-kong-2023-44487 / BIT-nginx-2023-44487 / BIT-nginx-ingress-controller-2023-44487 / BIT-node-2023-44487 / BIT-node-min-2023-44487 / BIT-solr-2023-44487 / BIT-tomcat-2023-44487 / BIT-varnish-2023-44487 / CGA-4mmr-qwxr-f88g / CGA-5jp5-95p2-jw83 / CGA-5v4r-558c-254r / CGA-9w4r-68hh-64j5 / CGA-m49h-wjp5-j434 / CGA-mp43-q6p3-96v2 / CVE-2023-44487 / GHSA-m425-mq94-257g / GHSA-qppj-fm5r-hxr3 / GO-2023-2153

More information

Details

An attacker can send HTTP/2 requests, cancel them, and send subsequent requests. This is valid by the HTTP/2 protocol, but would cause the gRPC-Go server to launch more concurrent method handlers than the configured maximum stream limit, grpc.MaxConcurrentStreams. This results in a denial of service due to resource consumption.

Severity

Unknown

References

This data is provided by OSV and the Go Vulnerability Database (CC-BY 4.0).


HTTP/2 Stream Cancellation Attack

BIT-apisix-2023-44487 / BIT-aspnet-core-2023-44487 / BIT-contour-2023-44487 / BIT-dotnet-2023-44487 / BIT-dotnet-sdk-2023-44487 / BIT-envoy-2023-44487 / BIT-golang-2023-44487 / BIT-jenkins-2023-44487 / BIT-kong-2023-44487 / BIT-nginx-2023-44487 / BIT-nginx-ingress-controller-2023-44487 / BIT-node-2023-44487 / BIT-node-min-2023-44487 / BIT-solr-2023-44487 / BIT-tomcat-2023-44487 / BIT-varnish-2023-44487 / CGA-4mmr-qwxr-f88g / CGA-5jp5-95p2-jw83 / CGA-5v4r-558c-254r / CGA-9w4r-68hh-64j5 / CGA-m49h-wjp5-j434 / CGA-mp43-q6p3-96v2 / CVE-2023-44487 / GHSA-m425-mq94-257g / GHSA-qppj-fm5r-hxr3 / GO-2023-2153

More information

Details

HTTP/2 Rapid reset attack

The HTTP/2 protocol allows clients to indicate to the server that a previous stream should be canceled by sending a RST_STREAM frame. The protocol does not require the client and server to coordinate the cancellation in any way, the client may do it unilaterally. The client may also assume that the cancellation will take effect immediately when the server receives the RST_STREAM frame, before any other data from that TCP connection is processed.

Abuse of this feature is called a Rapid Reset attack because it relies on the ability for an endpoint to send a RST_STREAM frame immediately after sending a request frame, which makes the other endpoint start working and then rapidly resets the request. The request is canceled, but leaves the HTTP/2 connection open.

The HTTP/2 Rapid Reset attack built on this capability is simple: The client opens a large number of streams at once as in the standard HTTP/2 attack, but rather than waiting for a response to each request stream from the server or proxy, the client cancels each request immediately.

The ability to reset streams immediately allows each connection to have an indefinite number of requests in flight. By explicitly canceling the requests, the attacker never exceeds the limit on the number of concurrent open streams. The number of in-flight requests is no longer dependent on the round-trip time (RTT), but only on the available network bandwidth.

In a typical HTTP/2 server implementation, the server will still have to do significant amounts of work for canceled requests, such as allocating new stream data structures, parsing the query and doing header decompression, and mapping the URL to a resource. For reverse proxy implementations, the request may be proxied to the backend server before the RST_STREAM frame is processed. The client on the other hand paid almost no costs for sending the requests. This creates an exploitable cost asymmetry between the server and the client.

Multiple software artifacts implementing HTTP/2 are affected. This advisory was originally ingested from the swift-nio-http2 repo advisory and their original conent follows.

swift-nio-http2 specific advisory

swift-nio-http2 is vulnerable to a denial-of-service vulnerability in which a malicious client can create and then reset a large number of HTTP/2 streams in a short period of time. This causes swift-nio-http2 to commit to a large amount of expensive work which it then throws away, including creating entirely new Channels to serve the traffic. This can easily overwhelm an EventLoop and prevent it from making forward progress.

swift-nio-http2 1.28 contains a remediation for this issue that applies reset counter using a sliding window. This constrains the number of stream resets that may occur in a given window of time. Clients violating this limit will have their connections torn down. This allows clients to continue to cancel streams for legitimate reasons, while constraining malicious actors.

Severity

  • CVSS Score: 5.3 / 10 (Medium)
  • Vector String: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


Release Notes

grpc/grpc-go (org_golang_google_grpc)

v1.56.3: Release 1.56.3

Compare Source

Security

  • server: prohibit more than MaxConcurrentStreams handlers from running at once (CVE-2023-44487)

    In addition to this change, applications should ensure they do not leave running tasks behind related to the RPC before returning from method handlers, or should enforce appropriate limits on any such work.

v1.56.2: Release 1.56.2

Compare Source

  • status: To fix a panic, status.FromError now returns an error with codes.Unknown when the error implements the GRPCStatus() method, and calling GRPCStatus() returns nil. (#​6374)

v1.56.1: Release 1.56.1

Compare Source

  • client: handle empty address lists correctly in addrConn.updateAddrs

v1.56.0: Release 1.56.0

Compare Source

New Features

  • client: support channel idleness using WithIdleTimeout dial option (#​6263)
    • This feature is currently disabled by default, but will be enabled with a 30 minute default in the future.
  • client: when using pickfirst, keep channel state in TRANSIENT_FAILURE until it becomes READY (gRFC A62) (#​6306)
  • xds: Add support for Custom LB Policies (gRFC A52) (#​6224)
  • xds: support pick_first Custom LB policy (gRFC A62) (#​6314) (#​6317)
  • client: add support for pickfirst address shuffling (gRFC A62) (#​6311)
  • xds: Add support for String Matcher Header Matcher in RDS (#​6313)
  • xds/outlierdetection: Add Channelz Logger to Outlier Detection LB (#​6145)
  • xds: enable RLS in xDS by default (#​6343)
  • orca: add support for application_utilization field and missing range checks on several metrics setters
  • balancer/weightedroundrobin: add new LB policy for balancing between backends based on their load reports (gRFC A58) (#​6241)
  • authz: add conversion of json to RBAC Audit Logging config (#​6192)
  • authz: add support for stdout logger (#​6230 and #​6298)
  • authz: support customizable audit functionality for authorization policy (#​6192 #​6230 #​6298 #​6158 #​6304 and #​6225)

Bug Fixes

  • orca: fix a race at startup of out-of-band metric subscriptions that would cause the report interval to request 0 (#​6245)
  • xds/xdsresource: Fix Outlier Detection Config Handling and correctly set xDS Defaults (#​6361)
  • xds/outlierdetection: Fix Outlier Detection Config Handling by setting defaults in ParseConfig() (#​6361)

API Changes

  • orca: allow a ServerMetricsProvider to be passed to the ORCA service and ServerOption (#​6223)

v1.55.1: Release 1.55.1

Compare Source

  • status: To fix a panic, status.FromError now returns an error with codes.Unknown when the error implements the GRPCStatus() method, and calling GRPCStatus() returns nil. (#​6374)

v1.55.0: Release 1.55.0

Compare Source

Behavior Changes

New Features

  • xds/xdsclient: support ignore_resource_deletion server feature as per gRFC A53 (#​6035)
  • security/advancedtls: add min/max TLS version selection options (#​6007)

Bug Fixes

  • xds: stop routing RPCs to deleted clusters (#​6125)
  • client: fix race between stream creation and GOAWAY receipt, which could lead to spurious UNAVAILABLE stream errors (#​6142)

Performance Improvements

v1.54.1: Release 1.54.1

Compare Source

Bug Fixes

  • credentials/alts: revert a change that causes a crash in the handshaker

v1.54.0: Release 1.54.0

Compare Source

Behavior Changes

  • xds: remove support for xDS v2 transport API (#​6013)

New Features

  • server: expose SetSendCompressor API to set send compressor name (#​5744)
  • xdsclient: include Node proto only in the first discovery request message, to improve performance (#​6078)

Bug Fixes

  • metadata: fix validation logic and properly validate metadata appended via AppendToOutgoingContext (#​6001)
  • transport: do not close connections when we encounter I/O errors until after all data is consumed (#​6110)
  • ringhash: ensure addresses are consistently hashed across updates (#​6066)
  • xds/clusterimpl: fix a bug causing unnecessary closing and re-opening of LRS streams (#​6112)
  • xds: NACK route configuration if sum of weights of weighted clusters exceeds uint32_max (#​6085)

Documentation

  • resolver: update Resolver.Scheme() docstring to mention requirement of lowercase scheme names (#​6014)
  • resolver: document expected error handling of UpdateState errors (#​6002)
  • examples: add example for ORCA load reporting (#​6114)
  • examples: add an example to illustrate authorization (authz) support (#​5920)

v1.53.0: Release 1.53.0

Compare Source

API Changes

  • balancer: support injection of per-call metadata from LB policies (#​5853)
  • resolver: remove deprecated field resolver.Target.Endpoint and replace with resolver.Target.Endpoint() (#​5852)

New Features

  • xds/ringhash: introduce GRPC_RING_HASH_CAP environment variable to override the maximum ring size. (#​5884)
  • rls: propagate headers received in RLS response to backends (#​5883)

Bug Fixes

  • transport: drain client transport when streamID approaches MaxStreamID (#​5889)
  • server: after GracefulStop, ensure connections are closed when final RPC completes (#​5968)
  • server: fix a few issues where grpc server uses RST_STREAM for non-HTTP/2 errors (#​5893)
  • xdsclient: fix race which can happen when multiple load reporting calls are made at the same time. (#​5927)
  • rls: fix a data race involving the LRU cache (#​5925)
  • xds: fix panic involving double close of channel in xDS transport (#​5959)
  • gcp/observability: update method name validation (#​5951)

Documentation

v1.52.3: Release 1.52.3

Compare Source

Bug Fixes

  • Fix user-agent version

v1.52.1: Release 1.52.1

Compare Source

Bug Fixes

  • grpclb: rename grpclbstate package back to state (#​5963)

v1.52.0: Release 1.52.0

Compare Source

New Features

  • xdsclient: log node ID with verbosity INFO (#​5860)
  • ringhash: impose cap on max_ring_size to reduce possibility of OOMs (#​5801)

Behavior Changes

  • client: return an error from Dial if an empty target is passed and no custom dialer is present; the ClientConn would otherwise be unable to connect and perform RPCs (#​5732)

Bug Fixes

  • transport (net/http server handler): respond to bad HTTP requests with status 400 (Bad Request) instead of 500 (Internal Server Error). (#​5804)
  • transport: Fixed closing a closed channel panic in handlePing (#​5854)
  • server: fix ChainUnaryInterceptor and ChainStreamInterceptor to allow retrying handlers (#​5666)
  • transport: ensure value of :authority header matches server name used in TLS handshake when the latter is overridden by the name resolver (#​5748)

Documentation

  • examples: add an example to illustrate the usage of stats handler (#​5657)
  • examples: add new example to show updating metadata in interceptors (#​5788)

v1.51.0: Release 1.51.0

Compare Source

Behavior Changes

  • xds: NACK EDS resources with duplicate addresses in accordance with a recent spec change (#​5715)
  • grpc: restrict status codes that can be generated by the control plane (gRFC A54) (#​5653)

New Features

  • client: set grpc-accept-encoding header with all registered compressors (#​5541)
  • xds/weightedtarget: return a more meaningful error when all child policies are in TRANSIENT_FAILURE (#​5711)
  • gcp/observability: add "started rpcs" metric (#​5768)
  • xds: de-experimentalize the google-c2p-resolver (#​5707)
  • balancer: add experimental Producer types and methods (#​5669)
  • orca: provide a way for LB policies to receive OOB load reports (#​5669)

Bug Fixes

  • go.mod: upgrade x/text dependency to address CVE 2022-32149 (#​5769)
  • client: fix race that could lead to an incorrect connection state if it was closed immediately after the server's HTTP/2 preface was received (#​5714)
  • xds: ensure sum of the weights of all EDS localities at the same priority level does not exceed uint32 max (#​5703)
  • client: fix binary logging bug which logs a server header on a trailers-only response (#​5763)
  • balancer/priority: fix a bug where unreleased references to removed child policies (and associated state) was causing a memory leak (#​5682)
  • xds/google-c2p: validate URI schema for no authorities (#​5756)

v1.50.1: Release 1.50.1

Compare Source

New Features

  • gcp/observability: support new configuration defined in public preview user guide

v1.50.0: Release 1.50.0

Compare Source

Behavior Changes

  • client: use proper "@​" semantics for connecting to abstract unix sockets. (#​5678)

    • This is technically a bug fix; the result is that the address was including a trailing NULL byte, which it should not have. This may break users creating the socket in Go by prefixing a NULL instead of an "@​", though, so calling it out as a behavior change.

New Features

  • metadata: add experimental ValueFromIncomingContext to more efficiently retrieve a single value (#​5596)
  • stats: provide peer information in HandleConn context (#​5589)
  • xds: add support for Outlier Detection, enabled by default (#​5435, #​5673)

Bug Fixes

  • client: fix deadlock in transport caused by GOAWAY racing with stream creation (#​5652)
    • This should only occur with an HTTP/2 server that does not follow best practices of an advisory GOAWAY (not a grpc-go server).
  • xds/xdsclient: fix a bug which was causing routes with cluster_specifier_plugin set to be NACKed when GRPC_EXPERIMENTAL_XDS_RLS_LB was off (#​5670)
  • xds/xdsclient: NACK cluster resource if config_source_specifier in lrs_server is not self (#​5613)
  • xds/ringhash: fix a bug which sometimes prevents the LB policy from retrying connection attempts (#​5601)
  • xds/ringhash: do nothing when asked to exit IDLE instead of falling back on the default channel behavior of connecting to all addresses (#​5614)
  • xds/rls: fix a bug which was causing the channel to be stuck in IDLE (#​5656)
  • alts: fix a bug which was setting WaitForReady on handshaker service RPCs, thereby delaying fallback when required (#​5620)
  • gcp/observability: fix End() to cleanup global state correctly (#​5623)

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@redhat-renovate-bot redhat-renovate-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 4, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akrejcir for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XS labels Dec 4, 2024
Copy link

sonarqubecloud bot commented Dec 4, 2024

@akrejcir
Copy link
Collaborator

akrejcir commented Dec 6, 2024

This is a strange change. We usually don't change vendor directory directly.

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2024
@redhat-renovate-bot redhat-renovate-bot force-pushed the renovate/main-go-org_golang_google_grpc-vulnerability branch from 083e2be to c58b82f Compare December 18, 2024 02:12
Copy link

openshift-ci bot commented Dec 18, 2024

@redhat-renovate-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-single-node-functests c58b82f link true /test e2e-single-node-functests
ci/prow/e2e-functests c58b82f link true /test e2e-functests
ci/prow/unittests c58b82f link true /test unittests
ci/prow/images c58b82f link true /test images
ci/prow/e2e-upgrade-functests c58b82f link true /test e2e-upgrade-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants