Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.18] Alert VMStorageClassWarning only for Windows VMs #1126

Open
wants to merge 2 commits into
base: release-v0.18
Choose a base branch
from

Conversation

machadovilaca
Copy link
Member

What this PR does / why we need it:

This is a manual cherry-pick of #984 and #1122

Which issue(s) this PR fixes:

Fixes #

jira-ticket: https://issues.redhat.com/browse/CNV-50785

Special notes for your reviewer:

Release note:

Alert VMStorageClassWarning only for Windows VMs

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 11, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ksimon1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5 Security Hotspots
C Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@machadovilaca
Copy link
Member Author

/retest

@akrejcir
Copy link
Collaborator

akrejcir commented Nov 12, 2024

Are you going to open a PR for later versions too?

@machadovilaca
Copy link
Member Author

Are you going to open a PR for later versions too?

yes

@machadovilaca
Copy link
Member Author

/hold

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@sradco
Copy link
Collaborator

sradco commented Nov 21, 2024

@machadovilaca what is the status of this PR?

@machadovilaca
Copy link
Member Author

@machadovilaca what is the status of this PR?

due to the metrics bug in the kubevirt repo, the e2e tests here are failing, the fix was already merged, ill try again this later today

@machadovilaca
Copy link
Member Author

/retest

1 similar comment
@machadovilaca
Copy link
Member Author

/retest

Copy link

openshift-ci bot commented Dec 9, 2024

@machadovilaca: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-single-node-functests 3804429 link true /test e2e-single-node-functests
ci/prow/e2e-functests 3804429 link true /test e2e-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants