-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v0.18] Alert VMStorageClassWarning only for Windows VMs #1126
base: release-v0.18
Are you sure you want to change the base?
[release-v0.18] Alert VMStorageClassWarning only for Windows VMs #1126
Conversation
Signed-off-by: João Vilaça <[email protected]>
Signed-off-by: João Vilaça <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
/retest |
Are you going to open a PR for later versions too? |
yes |
/hold |
@machadovilaca what is the status of this PR? |
due to the metrics bug in the kubevirt repo, the e2e tests here are failing, the fix was already merged, ill try again this later today |
/retest |
1 similar comment
/retest |
@machadovilaca: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This is a manual cherry-pick of #984 and #1122
Which issue(s) this PR fixes:
Fixes #
jira-ticket: https://issues.redhat.com/browse/CNV-50785
Special notes for your reviewer:
Release note: