Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64: Update arm64 lanes to use the newer kind-1.31 cluster provider #3827

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @dhiller @zhlhahaha @lyarwood

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


@kubevirt-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2024
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 13, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from brianmcarey. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@brianmcarey
Copy link
Member Author

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-kubevirt-functest-ubuntu-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-fedora-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64
rehearsal-pull-kubevirt-conformance-arm64
rehearsal-pull-kubevirt-e2e-arm64

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@zhlhahaha
Copy link
Contributor

Hi Brian, I will try to fix kubevirt/kubevirt#13501 first, then verify the PR.

@zhlhahaha
Copy link
Contributor

zhlhahaha commented Dec 17, 2024

  • verfiy pull-kubevirt-e2e-arm64 on kind-1.31
Ran 102 of 1409 Specs in 4086.207 seconds
SUCCESS! -- 102 Passed | 0 Failed | 3 Pending | 1304 Skipped
PASS
  • verify pull-kubevirt-conformance-arm64 on kind-1.31
Ran 16 of 1409 Specs in 2136.016 seconds
SUCCESS! -- 16 Passed | 0 Failed | 3 Pending | 1390 Skipped
PASS
  • verify parallel running e2e tests on kind-1.31
    Parallelly run 3 e2e tests, and all tests pass.

@zhlhahaha
Copy link
Contributor

Hi @brianmcarey , it works fine on my local environment. I have list the tests I done in the previous comment.

@brianmcarey
Copy link
Member Author

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-kubevirt-functest-fedora-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-ubuntu-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64
rehearsal-pull-kubevirt-e2e-arm64
rehearsal-pull-kubevirt-conformance-arm64

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@brianmcarey
Copy link
Member Author

@0xFelix @lyarwood I am trying to bump the kind clusters used for the arm builds in common-instancetypes - it looks like it fails on a cleanup from common-instancetypes?
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3827/rehearsal-pull-common-instancetypes-kubevirt-functest-fedora-arm64/1869352353950339072

@0xFelix
Copy link
Member

0xFelix commented Dec 18, 2024

Not sure that'll make a difference but can you rebase on main to see if the latest changes to the golang version and the builder image help in any way?

@brianmcarey
Copy link
Member Author

/rehearse

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-ubuntu-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-fedora-arm64
rehearsal-pull-kubevirt-e2e-arm64
rehearsal-pull-kubevirt-conformance-arm64

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@kubevirt-bot
Copy link
Contributor

@brianmcarey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-arm64 34f89a0 link unknown /test pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-ubuntu-arm64 34f89a0 link unknown /test pull-common-instancetypes-kubevirt-functest-ubuntu-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64 34f89a0 link unknown /test pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-fedora-arm64 34f89a0 link unknown /test pull-common-instancetypes-kubevirt-functest-fedora-arm64
pull-project-infra-lint 34f89a0 link true /test pull-project-infra-lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lyarwood
Copy link
Member

/rehearse rehearsal-pull-kubevirt-e2e-arm64

@kubevirt-bot
Copy link
Contributor

⚠️ @lyarwood you need to be an approver for all the files to run rehearsal.

@vladikr can help run the rehearsal.

If that doesn't work, ping someone from this list:

  • dhiller
  • phoracek
  • rmohr
  • vladikr
  • xpivarc
  • aglitke
  • brianmcarey
  • davidvossel
  • enp0s3
  • tiraboschi

@lyarwood
Copy link
Member

@brianmcarey this looks like a failure within kubevirtci tbh, I'd like to see rehearsal-pull-kubevirt-e2e-arm64 run if you could trigger the run?

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:


You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@brianmcarey
Copy link
Member Author

brianmcarey commented Dec 19, 2024

/rehearse pull-kubevirt-e2e-arm64

The reporting is currently not turned on for the arm64 e2e lanes as there are a couple of known test failures but heres the link to the rehearsal.
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3827/rehearsal-pull-kubevirt-e2e-arm64/1869756173444452352

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-arm64

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@lyarwood
Copy link
Member

/rehearse pull-kubevirt-e2e-arm64

The reporting is currently not turned on for the arm64 e2e lanes as there are a couple of known test failures but heres the link to the rehearsal. https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3827/rehearsal-pull-kubevirt-e2e-arm64/1869756173444452352

Interesting, that deploys at least. I'll look more in the morning, thanks!

@zhlhahaha
Copy link
Contributor

zhlhahaha commented Dec 20, 2024

/rehearse pull-kubevirt-e2e-arm64

The reporting is currently not turned on for the arm64 e2e lanes as there are a couple of known test failures but heres the link to the rehearsal. https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3827/rehearsal-pull-kubevirt-e2e-arm64/1869756173444452352

The fix for one of the failures (the softboot test) is still under discussion. Other failures stem from new patches and have only appeared since yesterday. I need to investigate these issues further.

You can compare the rehearsal test reports between December 18 and December 19

@zhlhahaha
Copy link
Contributor

Hi, @brianmcarey @lyarwood, I have submitted a PR to use the decorator to mark arm64 related tests. We may wait for that PR get merged. kubevirt/kubevirt#13578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants