Update test-infra dependency to make use of new prowjob config fields

[brianmcarey]

As part of the phased plugin work we are introducing a new field run_before_merge to some of our prowjobs - this is not available in the version of test-infra that is currently in place and as a result the automation removes this field[1] from our configs.

Update test-infra to the latest version in order to allow using this field.

[1] #3198 (comment)

/cc @oshoval @dhiller

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from brianmcarey. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dhiller]

I figure the tests are failing since in later test-infra versions bazel has been removed.

[oshoval]

tried to convert quickly git to git v2 here
unit tests pass (beside a test that isn't related that didnt pass also before), all CI lanes pass
#3203

maybe worth to combine the PRs and see ?
we are already using v2 on most places, just botreview didn't so if this will be the only problem we should
be fine

[oshoval]

I figure the tests are failing since in later test-infra versions bazel has been removed.

btw maybe we can bump to a version where the new field does exists and also Bazel, if we conclude that
it is blocking (in case such version do exists)
same if we find a version where git/v1 is supported + the field exists

[brianmcarey]

I figure the tests are failing since in later test-infra versions bazel has been removed.

Yeah it looks like we have further bazel issues here.

[oshoval]

I figure the tests are failing since in later test-infra versions bazel has been removed.

Yeah it looks like we have further bazel issues here.

do we want to try and fix them ?
or to do some workaround until tide is fixed and the new flag is not used? (started kubernetes/test-infra#31687 but not sure how long it will take)
(for example to add some ad hoc hack that revert just changes to this line, if the job is kept)
we can also try to find a version like mentioned above, if exists)

[kubevirt-bot]

@brianmcarey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-project-infra-test-external-plugins	0f8db5e	link	true	/test pull-project-infra-test-external-plugins
pull-project-infra-test-robots	0f8db5e	link	true	/test pull-project-infra-test-robots
pull-project-infra-grafana-deploy-test	0f8db5e	link	true	/test pull-project-infra-grafana-deploy-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[oshoval]

a pretty proper fix can be something like done here
#3126
agnostic of the struct, in case the job wasn't remove, check the name of it, and take it vanilla using the logic that appears on mentioned PR, this way it won't pass via the unmarsheling that can remove fields iiuc

another option is to present an updated struct, just for the parsing

[kubevirt-bot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[brianmcarey]

/close

[kubevirt-bot]

@brianmcarey: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.