Enable e2e lanes for latest kubernetes version #3188
Conversation
Signed-off-by: kubevirt-bot <[email protected]>
|
@kubevirt-bot: GitHub didn't allow me to request PR reviews from the following users: kubevirt/prow-job-taskforce. Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubevirt-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
do-not-merge/hold
| @@ -801,7 +801,6 @@ presubmits: | |||
| securityContext: | |||
| privileged: true | |||
| - always_run: false | |||
| run_before_merge: true | |||
There was a problem hiding this comment.
we do want to keep it phase 2 , so please keep this line
| @@ -17,6 +16,7 @@ presubmits: | |||
| preset-podman-in-container-enabled: "true" | |||
| max_concurrency: 1 | |||
| name: pull-kubevirtci-bump-kubevirt | |||
| optional: true | |||
There was a problem hiding this comment.
why is it moved ? automatically ?
There was a problem hiding this comment.
IIRC that is part of the automation, which when writing back the changed file automatically sorts alphabetically.
There was a problem hiding this comment.
yes u right, saw it also on #3126
weird that it is a map, and map on go isnt sorted, but this is what it is
|
do you want to bump pull-kubevirt-e2e-k8s-1.28-sig-compute-migrations to 1.29 as well here ? |
kubevirt-bot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close |
|
@brianmcarey: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Enable lanes for latest kubernetes version and disable lanes with unsupported version
/cc @kubevirt/prow-job-taskforce