tests/infra/Prometheus: create token for test executor to interact with Prometheus resources #13534
+112
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note-none
|
/cc @xpivarc if this fix doesn't look good enough, we can try to switch to a http.Client with the TLSClientConfig that we extract from the executor kubeconfig, and remove the exec command completely.. |
dosubot
bot
added
the
sig/observability
kubevirt-bot
added
the
do-not-merge/work-in-progress
kubevirt-bot
removed
the
do-not-merge/work-in-progress
kubevirt-bot
added
the
do-not-merge/work-in-progress
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
4f164a2 to
a4432d4
Compare
kubevirt-bot
added
size/M
and removed
do-not-merge/work-in-progress
dasionov
changed the title
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
2 times, most recently
from
09d6048 to
37fea97
Compare
This commit sets up a ServiceAccount for the test executor to use when making requests to the Kubernetes API to interact with the Prometheus resource and its subresources. This ensures the tests can authenticate properly and access the required endpoints. Signed-off-by: Daniel Sionov <[email protected]>
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
37fea97 to
7fd7487
Compare
|
/test pull-kubevirt-e2e-k8s-1.30-sig-monitoring |
|
@dasionov: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
b11a5bd to
82e225e
Compare
|
/test pull-kubevirt-e2e-k8s-1.31-sig-monitoring |
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
82e225e to
5b6c953
Compare
|
/test pull-kubevirt-e2e-k8s-1.31-sig-monitoring |
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
5b6c953 to
dd15c32
Compare
|
/test pull-kubevirt-e2e-k8s-1.31-sig-monitoring |
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
dd15c32 to
68e815c
Compare
|
/test pull-kubevirt-e2e-k8s-1.31-sig-monitoring |
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
68e815c to
3097377
Compare
|
/test pull-kubevirt-e2e-k8s-1.31-sig-monitoring |
|
/test pull-kubevirt-e2e-k8s-1.31-sig-compute |
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
9fc6cee to
3097377
Compare
|
/test pull-kubevirt-e2e-k8s-1.31-sig-monitoring |
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
3097377 to
4489123
Compare
|
/test ? |
|
@xpivarc: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-kubevirt-e2e-k8s-1.31-sig-monitoring |
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
4489123 to
7c0c5a3
Compare
Signed-off-by: Daniel Sionov <[email protected]>
dasionov
force-pushed
the
fix_qurantined_prometheus_test
branch
from
7c0c5a3 to
5e822ab
Compare
|
/test pull-kubevirt-e2e-k8s-1.31-sig-monitoring |
1 similar comment
|
/test pull-kubevirt-e2e-k8s-1.31-sig-monitoring |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xpivarc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Required labels detected, running phase 2 presubmits: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR
This Pr fixes what #13372 tried to accomplish.
The kubeconfig doesn't use a token for the admin, which renders the
config.BearerTokenempty.After this PR
The test now creates a dedicated
ServiceAccountand uses a generated token for authentication. This token is explicitly associated with the required permissions to access Prometheus-related resources and subresources. This replaces the incorrect reliance onBearerTokenand ensures proper authentication.Fixes #
Release note