-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(renovate): Add renovate config #128
Conversation
Add renovate configuration to automatically update used software versions in e2e-setup and the github actions used by this repository. Signed-off-by: Felix Matouschek <[email protected]>
0780fce
to
ddd3118
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
{ | ||
"customType": "regex", | ||
"fileMatch": ["^.github/workflows/integration.yml$"], | ||
"matchStrings": ["\\sversion: (?<currentValue>.*?)\\n"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it consider value as version: v1.2.3
and also version: 1.2.3
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you test this regex? in regexr.com
or somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would match both, but v1.2.3
is what's being used.
Yes, or regex101.com.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! :)
@@ -0,0 +1,68 @@ | |||
{ | |||
"$schema": "https://docs.renovatebot.com/renovate-schema.json", | |||
"extends": [":gitSignOff"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add this line https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/renovate.json#L4
which will create nice dashboard of dependencies like kubevirt/kubevirt-tekton-tasks#496
/lgtm |
/hold Need to wait until this repo is onboarded to the redhat-renovate-bot |
/hold cancel redhat-renovate-bot is active on this repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add renovate configuration to automatically update used software versions in e2e-setup and the github actions used by this repository.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: