Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(renovate): Add renovate config #128

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Aug 14, 2024

What this PR does / why we need it:

Add renovate configuration to automatically update used software versions in e2e-setup and the github actions used by this repository.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

None

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 14, 2024
Add renovate configuration to automatically update used software
versions in e2e-setup and the github actions used by this repository.

Signed-off-by: Felix Matouschek <[email protected]>
Copy link
Member

@codingben codingben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2024
{
"customType": "regex",
"fileMatch": ["^.github/workflows/integration.yml$"],
"matchStrings": ["\\sversion: (?<currentValue>.*?)\\n"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it consider value as version: v1.2.3 and also version: 1.2.3?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test this regex? in regexr.com or somewhere else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would match both, but v1.2.3 is what's being used.

Yes, or regex101.com.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! :)

@@ -0,0 +1,68 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [":gitSignOff"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add this line https://github.com/kubevirt/kubevirt-tekton-tasks/blob/main/renovate.json#L4
which will create nice dashboard of dependencies like kubevirt/kubevirt-tekton-tasks#496

@ksimon1
Copy link
Member

ksimon1 commented Aug 14, 2024

/lgtm

@0xFelix
Copy link
Member Author

0xFelix commented Aug 16, 2024

/hold Need to wait until this repo is onboarded to the redhat-renovate-bot

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2024
@0xFelix
Copy link
Member Author

0xFelix commented Aug 28, 2024

/hold cancel
/approve

redhat-renovate-bot is active on this repository.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2024
@kubevirt-bot kubevirt-bot merged commit 2aced29 into kubevirt:main Aug 28, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants