fix(CNV-53189): make PUSH_TIMEOUT an optional param #575
Conversation
Tekton parameter PUSH_TIMEOUT is not required and can use default value if not set, which is timeout of 2 hours (120 minutes). Signed-off-by: Ben Oukhanov <[email protected]>
kubevirt-bot
added
release-note
| @@ -38,6 +38,7 @@ spec: | |||
| - name: PUSH_TIMEOUT | |||
| description: ContainerDisk push timeout in minutes | |||
| type: string | |||
| default: "120" | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix, codingben The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Can the PUSH_TIMEOUT also from the example in the README.md , to keep it as simple as possible? |
|
@codingben: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
It's mentioned in the parameters, this is what you mean? |
I am referring to the example in the usage section: |
What this PR does / why we need it:
Tekton parameter PUSH_TIMEOUT is not required
and can use default value if not set, which is
timeout of 2 hours (120 minutes).
Release note: