Add multiplatform support for ipam-controller image. #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable build process to support various architectures (e.g., amd64, arm64, and s390x) for ipam-controller. Signed-off-by: Ashok Pariya <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
dco-signoff: yes
|
Thanks @RamLavi is going to remove passt, so the part about passt isnt needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable build process to support various architectures (e.g., amd64, arm64, and s390x) for ipam-controller.
What this PR does / why we need it:
Currently, the ipam-controller image is supported only on the amd64 architecture. You can find the image here: ipam-controller image. With the changes from these PRs, we are now able to build and push an image that supports multiple platforms.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
We plan to extend support for the passt-binding image to multiple architectures once binaries for other platforms become available. Currently, it only supports the amd64 architecture. You can find the binary here: passt-binding
Release note: