Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.56] Allow Deployed CDI to get out of Error Phase #3111

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

mhenriks
Copy link
Member

What this PR does / why we need it:

manual backport of #3080

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

https://issues.redhat.com/browse/CNV-38363

Special notes for your reviewer:

Release note:

BugFix:  Allow Deployed CDI to get out of Error Phase

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 22, 2024
@mhenriks
Copy link
Member Author

/retest-required

WORKSPACE Outdated
name = "buildah-1__1.31.3-1.el9.aarch64",
sha256 = "75cee8238006cd2ad42054a66cb93a36d429c86d661d293a632c19acf87b24a9",
urls = ["http://mirror.stream.centos.org/9-stream/AppStream/aarch64/os/Packages/buildah-1.31.3-1.el9.aarch64.rpm"],
name = "buildah-2__1.33.5-1.el9.aarch64",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come these are needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was getting 404s on rpms so did make rpm-deps

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2024
@kubevirt-bot kubevirt-bot added size/M and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL labels Feb 29, 2024
@mhenriks
Copy link
Member Author

@akalenyu rebased on #3111 but still had an issue with crun. Unfortunately we don't have our own mirror for kubevirt/kubevirt

@akalenyu
Copy link
Collaborator

@akalenyu rebased on #3111 but still had an issue with crun. Unfortunately we don't have our own mirror for kubevirt/kubevirt

Guess you mean #3113, yeah, we will have to wait for an infra based solution (kubevirt/project-infra#3097)

/approve
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 29, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@kubevirt-bot kubevirt-bot merged commit ddee9f2 into kubevirt:release-v1.56 Feb 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants