Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding maintainer responsibilities, off-boarding, and emeritus governance docs #366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aburdenthehand
Copy link
Member

  1. Adding maintainer responsibilities, since we mention this as part of our selection criteria.
  2. Also adding off-boarding/retiring expectations for maintainers, something we've been talking about throughout the year but never put into our docs. It is also a part of CNCF graduation criteria, so let's put it into our docs.
  3. Also also adding an opening para that links to our membership policy, to make that more obvious for anyone looking for that info in our governance doc. This is mirrored by adding project maintainers to our contribution ladder in the membership policy, linking back to governance, and to our maintainers file.

Fixes #311

As per our governance, this requires a 2/3 vote of maintainers to update.
/cc @fabiand @davidvossel @rthallisey @rmohr @vasiliy-ul @vladikr @stu-gott

Release note:

Adding responsibilities and offboarding expectations for maintainers

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Dec 10, 2024
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from aburdenthehand. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vladikr
Copy link
Member

vladikr commented Dec 15, 2024

Thanks @aburdenthehand
We discussed this offline as well.
/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2024
@kubevirt-bot
Copy link

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Dec 22, 2024
Copy link
Contributor

@iholder101 iholder101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aburdenthehand!
Looks great to me. Left some nits.

/lgtm

Comment on lines +45 to +46
* Responsive to issues raised on the cncf-maintainers list.
* Responsive to issues raised on the security list and CVEs to coordinate and prioritise remediation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add links here?

Maintainers share the highest level of responsibilities for the project and take the broadest viewpoint.
They help steer the technical direction of the project as well as shepherd the community so that it is always forward thinking and sustainable.

The core responsibilities of our maintainers are:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about:

  • Heavily involved in the project's hottest topics, like Enhancement Proposals, important PRs and code-reviews, organizational changes, etc

My point is that a maintainer should be heavily involved, present and visible in the project. Does that make sense?

project.

Removing a maintainer requires a 2/3 majority vote of the other maintainers.
Should a maintainer retire or be demoted and wish to return, it requires a majority vote of the current maintainers to reinstate them.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could add something like: "Although requiring a vote by maintainer, it should be much easier for an emeritus maintainer to return becoming a maintainer"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-approver-review Indicates that a PR requires a review from an approver. size/M
Projects
None yet
4 participants