Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new SIG governance and tooling #236

Closed
wants to merge 18 commits into from
Closed

Conversation

lyarwood
Copy link
Member

@lyarwood lyarwood commented Aug 8, 2023

@kubevirt-bot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 8, 2023
@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cwilkers for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iholder101
Copy link
Contributor

/cc

@dhiller
Copy link
Contributor

dhiller commented Aug 10, 2023

@lyarwood please note that the sigs.yaml file is required to update the CNCF stats for KubeVirt.

I will need to check whether the changes impact the stats generation.

/assign

@dhiller
Copy link
Contributor

dhiller commented Aug 10, 2023

/cc

@kubevirt-bot kubevirt-bot requested a review from dhiller August 10, 2023 13:19
@dhiller
Copy link
Contributor

dhiller commented Aug 14, 2023

/test ?

@kubevirt-bot
Copy link

@dhiller: The following commands are available to trigger required jobs:

  • /test pull-community-generate-kubevirt-devstats-repo-sql
  • /test pull-community-validate-sigs-yaml

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhiller
Copy link
Contributor

dhiller commented Aug 14, 2023

/test pull-community-generate-kubevirt-devstats-repo-sql
/test pull-community-validate-sigs-yaml

sigs.yaml Show resolved Hide resolved
sigs.yaml Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Show resolved Hide resolved
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed that we are missing some labels in the config, therefore I've created a WIP PR: kubevirt/project-infra#2953

Other than that looks good to me.

sigs.yaml Outdated Show resolved Hide resolved
sigs.yaml Outdated Show resolved Hide resolved
sigs.yaml Outdated Show resolved Hide resolved
sigs.yaml Outdated Show resolved Hide resolved
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
GOVERNANCE.md Outdated Show resolved Hide resolved
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@kubevirt-bot
Copy link

New changes are detected. LGTM label has been removed.

@lyarwood
Copy link
Member Author

/hold

I'm likely going to break this up into a few different PRs after the call tomorrow.

@lyarwood lyarwood changed the title WIP - Update SIGs Introduce new SIG governance and tooling Sep 14, 2023
@lyarwood
Copy link
Member Author

/unhold

As discussed in the latest SIGs - What's Next? [1] meeting I think the PR is getting to the stage now where we should land what we have and work to refine it through engaging the existing SIGs to populate the required metadata.

I'm hopeful that this process will help us iron out any issues and nits with the process instead of this PR forever being in review and not moving the overall SIG process forward.

Once merged I'm going to use the SIGs - What's Next? call to help on-board folks into the process and set out what is required going forward.

[1] https://docs.google.com/document/d/1yOtxWS2eIgA2VT71NbFaDEzGyVfmiDCwoRBHKow0K6c/edit

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2023
@lyarwood lyarwood marked this pull request as ready for review September 14, 2023 14:41
@kubevirt-bot kubevirt-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
Copy link
Member

@aburdenthehand aburdenthehand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @lyarwood
I've done a run through and picked up some changes re: steering committee and some kubernetes info, and updated the slack channels etc. I've also tried to slim down some of the weight that I don't think applies to our project.

* Horizontal: Scalability, Architecture
* Project: Testing, Release, Docs

SIGs must have at least one and ideally two SIG chairs at any given time. SIG chairs are intended to be organizers and facilitators, responsible for the operation of the SIG and for communication and coordination with the other SIGs, the Steering Committee, and the broader community.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, at this stage we would prefer a 'SIG Governance' or similar to help out with process and decision making of creating/maintaining SIGs rather than a steering committee.
This line then might be better as "...coordination with the other SIGs, particularly SIG Governance, and the broader..." or similar.

There's 40-odd references to steering committee in this PR atm which we should probably change (or remove the file entirely).


# Liaisons

Steering Committee members are elected representatives of the kubevirt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably drop this file for the time being, as any SIG should be able to reach out to any of the SIG-governance members, no?

and a link to the PR in the body.
8. Typically expect feedback within a week of sending your draft. Expect longer time if it falls over an
event such as KubeCon/CloudNativeCon or holidays. Make any necessary changes.
9. Once accepted, the steering committee will ratify the PR by merging it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
9. Once accepted, the steering committee will ratify the PR by merging it.
9. Once accepted, a member of SIG Governance will ratify the PR by merging it.

## Steps to update an existing SIG charter

- For significant changes, or any changes that could impact other SIGs, such as the scope, create a
PR and send it to the steering committee for review with the subject: "SIG Charter Update: YOURSIG"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PR and send it to the steering committee for review with the subject: "SIG Charter Update: YOURSIG"
PR and tag `sig-governance` for review.

?

Comment on lines +39 to +42
Make sure to keep the SIG in the loop as discussions progress with the Steering Committee (next step).
Including the SIG mailing list in communications with the steering committee would work for this.
- Work with the steering committee (Approvers) to gain approval.
This can simply be submitting a PR and sending mail to [[email protected]].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Make sure to keep the SIG in the loop as discussions progress with the Steering Committee (next step).
Including the SIG mailing list in communications with the steering committee would work for this.
- Work with the steering committee (Approvers) to gain approval.
This can simply be submitting a PR and sending mail to [[email protected]].
- Work with SIG Governance maintainers to gain approval.

- WG README: [`wg_readme.tmpl`](wg_readme.tmpl)
- Committee README: [`committee_readme.tmpl`](committee_readme.tmpl)

**Time Zone gotcha**:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using UTC removes the issue of daylight savings, and the KubeVirt calendar updates times depending on the user/browser location.

@@ -0,0 +1,35 @@
{{lastYear}} Annual Report: {{.Prefix | toUpper}} {{.Name}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these three annual report files?

Comment on lines +65 to +67
{{- if .Contact.Liaison.Name }}
- Steering Committee Liaison: {{.Contact.Liaison.Name}} (**[@{{.Contact.Liaison.GitHub}}](https://github.com/{{.Contact.Liaison.GitHub}})**)
{{- end }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we can drop these lines

@@ -0,0 +1,45 @@
{{ template "header" }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before, I don't think we need specific liaisons

{{- end }}

## Contact
- Slack: [#{{.Contact.Slack}}](https://kubevirt.slack.com/messages/{{.Contact.Slack}})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Slack: [#{{.Contact.Slack}}](https://kubevirt.slack.com/messages/{{.Contact.Slack}})
- Slack: [#{{.Contact.Slack}}](https://kubernetes.slack.com/messages/kubevirt-dev{{.Contact.Slack}})

@kubevirt-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2023
@kubevirt-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 13, 2024
@aburdenthehand aburdenthehand added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 31, 2024
@lyarwood
Copy link
Member Author

/close

See https://groups.google.com/g/kubevirt-dev/c/dXvwU6Pon7Y for more context.

@lyarwood lyarwood closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants