-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reconciling and restoring infra EndpointSlices #336
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andrei Kvapil <[email protected]>
295b50c
to
480cb31
Compare
/assign @qinqon |
Upstream fixes: - kubevirt/cloud-provider-kubevirt#335 - kubevirt/cloud-provider-kubevirt#336 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **New Features** - Incremented Kubernetes chart version to 0.14.1. - Introduced a new cloud provider controller for managing EndpointSlices in KubeVirt, enhancing responsiveness to service changes. - **Improvements** - Updated Docker image tag for kubevirt-cloud-provider to use the latest version. - Enhanced handling of EndpointSlices for LoadBalancer services, improving service management. - **Bug Fixes** - Improved error handling and logging for service retrieval and EndpointSlice management. - **Documentation** - Updated version mappings in the versions map file for clarity and tracking. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Andrei Kvapil <[email protected]>
@klinch0: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR introduces the following key changes to the
kubevirteps
controller:EndpointSlice
events (add, update, delete) in the infra cluster.EndpointSlice
is deleted and automatically re-queues the associated Service for reconciliation.reconcile
logic: Improved thegetInfraServiceForEPS
function to mapEndpointSlices
back to their associated infraServices
using labels.EndpointSlice
after manual deletion.EndpointSlices
when associatedServices
are modified.These improvements enhance the controller's resilience and ensure that infra
EndpointSlices
are consistently in sync with the desired state.