Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Use a path different from the key in the ConfigMap #49219

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ja] Use a path different from the key in the ConfigMap #49219

wants to merge 1 commit into from

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Dec 23, 2024

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Dec 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nasa9084 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 23, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 23, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8140bfd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6769dee850b55e00084c9946
😎 Deploy Preview https://deploy-preview-49219--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dipesh-rawat
dipesh-rawat reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updates looks in sync with 'en' PR https://github.com/kubernetes/website/pull/49155/files

/lgtm

Preview Page

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 217ca5784a5afba3353b0e2bddce1b81f0ccb3d1

@nasa9084
Copy link
Member

thx
/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@atoato88 atoato88 Awaiting requested review from atoato88

@nasa9084 nasa9084 Awaiting requested review from nasa9084

Assignees

@nasa9084 nasa9084

@dipesh-rawat dipesh-rawat

Labels
area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Arhell @k8s-ci-robot @nasa9084 @dipesh-rawat