-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise advice about network plugin compatibility #47026
base: main
Are you sure you want to change the base?
Conversation
Add a clarification that CNI has been supported from earliest version, not just the current version.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -11,7 +11,7 @@ weight: 10 | |||
|
|||
<!-- overview --> | |||
|
|||
Kubernetes {{< skew currentVersion >}} supports [Container Network Interface](https://github.com/containernetworking/cni) | |||
Kubernetes since earliest releases, including {{< skew currentVersion >}} supports [Container Network Interface](https://github.com/containernetworking/cni) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure that this is a meaningful improvement to the documentation in terms of usefulness to the reader. If we are going to clarify here, we should include the specific version in which CNI plugin support was first introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do a related change:
-You must use a CNI plugin that is compatible with the
-[v0.4.0](https://github.com/containernetworking/cni/blob/spec-v0.4.0/SPEC.md) or later
-releases of the CNI specification. The Kubernetes project recommends using a plugin that is
+For Kubernetes {{< skew currentVersion >}} specifically, you must use a CNI plugin
+that is compatible with the
+[v0.4.0](https://github.com/containernetworking/cni/blob/spec-v0.4.0/SPEC.md) or later
+releases of the CNI specification.
+The Kubernetes project further recommends using a plugin that is
compatible with the [v1.0.0](https://github.com/containernetworking/cni/blob/spec-v1.0.0/SPEC.md)
CNI specification (plugins can be compatible with multiple spec versions).
+If you are running a version of Kubernetes other than v{{< skew currentVersion >}}, check the
+documentation for the release you're running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katcosgrove , my motivation with this change was to indicate that it is not just the latest, but CNI has been standard since kubernetes 1.3.0. Prior to that it was kube-net. So, want to indicate that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am open to rewording it to indicate this information.
/retitle Revise advice about network plugin compatibility |
/sig network |
Add a clarification that CNI has been supported from earliest version, not just the current version.