Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: add test workflow for testing ControlPlaneKubeletLocalMode feature gate #32858

Merged
merged 1 commit into from
Jul 15, 2024
Merged

kubeadm: add test workflow for testing ControlPlaneKubeletLocalMode feature gate #32858

merged 1 commit into from
Jul 15, 2024

Conversation

chrischdi
Copy link
Member

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2024
@chrischdi chrischdi changed the title kubeaedm: add test workflow for testing ControlPlaneKubeletLocalMode feature gate kubeadm: add test workflow for testing ControlPlaneKubeletLocalMode feature gate Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 27, 2024
@chrischdi chrischdi force-pushed the pr-kubeadm-cp-kubelet-local-tests branch from 74638b7 to 3712d65 Compare June 27, 2024 07:34
@chrischdi chrischdi mentioned this pull request Jun 27, 2024
Merged
@chrischdi
Copy link
Member Author

/cc @neolit123 @SataQiu @pacoxu @carlory

/uncc chases2 wojtek-t

@k8s-ci-robot k8s-ci-robot requested review from carlory, neolit123, pacoxu and SataQiu and removed request for chases2 and wojtek-t June 27, 2024 07:35
@chrischdi
Copy link
Member Author

/hold

To ensure everything is ok on the other PR first.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2024
@neolit123 neolit123 mentioned this pull request Jun 27, 2024
Open
2 tasks
@chrischdi chrischdi force-pushed the pr-kubeadm-cp-kubelet-local-tests branch 2 times, most recently from 8714523 to 55a26d4 Compare June 28, 2024 12:06
@neolit123
Copy link
Member

neolit123 commented Jul 1, 2024 •
edited
Loading

/approve
please update this PR after the latest generator output
there was one comment about -local -> local-mode

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@chrischdi chrischdi force-pushed the pr-kubeadm-cp-kubelet-local-tests branch from 55a26d4 to f2695f9 Compare July 1, 2024 16:39
neolit123
neolit123 reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
neolit123
neolit123 reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrischdi
Copy link
Member Author

/hold cancel

Thanks everyone!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@chrischdi chrischdi mentioned this pull request Jul 15, 2024
Open
5 tasks
@chrischdi
Copy link
Member Author

/hold

Discussions on the merged PR

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@chrischdi
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3a43683 into kubernetes:master Jul 15, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@chrischdi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeadm-kinder-control-plane-local-kubelet-mode.yaml using file config/jobs/kubernetes/sig-cluster-lifecycle/kubeadm-kinder-control-plane-local-kubelet-mode.yaml

In response to this:

xref: kubernetes/kubeadm#3080

xref: kubernetes/kubeadm#2271

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@carlory carlory Awaiting requested review from carlory

@pacoxu pacoxu Awaiting requested review from pacoxu

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrischdi @neolit123 @k8s-ci-robot