[NodeKiller] Schedule reboot and disconnect from node #1109
Conversation
k8s-ci-robot
added
cncf-cla: yes
| // 'nohup' - Making sure that end of SSH connection signal will not break sudo | ||
| // 'sudo' - Elevated priviliages, required by 'reboot' | ||
| // 'reboot' - Rebooting node | ||
| // '+1s' - Parameter to 'reboot', to wait 1 second before rebooting. |
There was a problem hiding this comment.
I might be wrong but I'm not sure whether reboot accepts such parameter. I checked sudo reboot --help on COS system and such feature wasn't documented anywhere.
There was a problem hiding this comment.
You are right, this should use shutdown command.
clusterloader2/pkg/chaos/nodes.go
Outdated
| // 'sudo' - Elevated priviliages, required by 'reboot' | ||
| // 'reboot' - Rebooting node | ||
| // '+1s' - Parameter to 'reboot', to wait 1 second before rebooting. | ||
| // '> /dev/null 2> /dev/null < /dev/null' - File descriptor redirect, as we are closing terminal |
There was a problem hiding this comment.
The explanation is not very clear. Wouldn't be better to write something like:
// redirect all three I/O to avoid ssh hanging, see https://web.archive.org/web/20090429074212/http://www.openssh.com/faq.html#3.10
?
There was a problem hiding this comment.
Added this comment
jprzychodzen
force-pushed
the
nodekiller-better-reboot
branch
from
ccec805
to
f1647f4
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jprzychodzen, mm4tt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
No description provided.