Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add k8s 1.30 to ci build #11526

Merged
merged 5 commits into from
Jul 3, 2024
Merged

add k8s 1.30 to ci build #11526

merged 5 commits into from
Jul 3, 2024

Conversation

strongjz
Copy link
Member

@strongjz strongjz commented Jul 1, 2024

upgrade all other versions to latest kind build

@strongjz
add k8s 1.30 to ci build
6071309 
Signed-off-by: James Strong <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 1, 2024
@k8s-ci-robot k8s-ci-robot requested review from Gacko and puerco July 1, 2024 15:24
@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Jul 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 1, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit e434652
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/6685995341722f00083179db

Gacko
Gacko reviewed Jul 1, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@Gacko
Copy link
Member

Gacko commented Jul 1, 2024

/triage accepted
/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Jul 1, 2024
@Gacko
Copy link
Member

Gacko commented Jul 1, 2024

/cherry-pick release-1.10

@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2024
Gacko
Gacko reviewed Jul 1, 2024
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@Gacko
Copy link
Member

Gacko commented Jul 3, 2024

Is there a reason not to use v1.30.2?

@strongjz
Copy link
Member Author

strongjz commented Jul 3, 2024

Is there a reason not to use v1.30.2?

it's based on the kind versions and it only has k8s 1.30.0 available in the latest release. https://github.com/kubernetes-sigs/kind/releases

@Gacko
Copy link
Member

Gacko commented Jul 3, 2024

Okay, weird... 🤦

@strongjz strongjz merged commit 973c1c9 into kubernetes:main Jul 3, 2024
45 of 46 checks passed
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 3, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11553

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko
Copy link
Member

Gacko commented Jul 4, 2024

/cherry-pick release-1.11

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 4, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link
Contributor

@Gacko: new pull request created: #11554

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gacko Gacko mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gacko Gacko Gacko left review comments

@puerco puerco Awaiting requested review from puerco

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@strongjz @k8s-ci-robot @Gacko @k8s-infra-cherrypick-robot