KEP 1645: add a derived service annotation on ServiceImport #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the implementation is using derived Service suggest adding the annotation `multicluster.kubernetes.io/derived-service` to ServiceImport objects to point toward the actual derived Service. This may help third party controllers like GatewayAPI to integrate/add MCS-API support. This formalize what was already being done in the mcs-api "reference implementation" here: https://github.com/kubernetes-sigs/mcs-api/blob/2833f83cfbdc46d80e0e18111ec977c4ef16e51d/pkg/controllers/serviceimport.go#L80-L90. Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MrFreezeex The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multicluster.kubernetes.io/derived-serviceto ServiceImport objects to point toward the actual derived Service.multicluster.kubernetes.io/derived-serviceto ServiceImport objects to point toward the actual derived Service. This may help third party controllers like GatewayAPI implementations to integrate/add MCS-API support. This formalize what was already being done in the mcs-api "reference implementation" here:https://github.com/kubernetes-sigs/mcs-api/blob/2833f83cfbdc46d80e0e18111ec977c4ef16e51d/pkg/controllers/serviceimport.go#L80-L90.