-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1287: InPlacePodVerticalScaling BETA update #4704
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tallclair The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tallclair: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- Impact of its outage on the feature: | ||
- Impact of its degraded performance or high-error rates on the feature: | ||
|
||
Compatible container runtime (see [CRI changes](#cri-changes)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps also addition of a RuntimeHandlerFeature for resize? as commented here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's more for the underlying oci runtimes to report features they have available. We could add features
to the runtime status object maybe, though I think the runtimes have been compatible for a while unless the design is changing
On further discussion, we've decided to push this back to v1.32. There are currently too many unresolved edge cases. I'll update this PR soon to highlight those unresolved conditions. /milestone v1.32 |
@@ -676,6 +676,26 @@ Other components: | |||
* check how the change of meaning of resource requests influence other | |||
Kubernetes components. | |||
|
|||
### Instrumentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think it could be useful to have this for 1.31 alpha to have that feedback going into beta?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think all the changes discussed for beta can go in while it's still in alpha, but I can specifically prioritize this one.
One-line PR description: Update PRR beta requirements sections
Issue link: In-Place Update of Pod Resources #1287
Other comments