Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP 1645: update conditions in ServiceExport after KEP-1623 #4672

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP 1645: update conditions in ServiceExport after KEP-1623 #4672

wants to merge 1 commit into from
+9 −25

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented May 30, 2024 •
edited
Loading

  • Other comments: Also swap the "2/5 cluster disagree" in the conflict message example so that it's clear that the disagree sentence is for the service that we export and not from the oldest Service that we conflict with.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrFreezeex
Once this PR has been reviewed and has the lgtm label, please assign pmorie for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 30, 2024
@MrFreezeex
KEP 1645: update conditions in ServiceExport after KEP-1623
ad87e76 
Also swap the "2/5 cluster disagree" in the conflict message so that it's
clear that the disagree sentence is for the service we export and not from
the oldest Service that we conflict with.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@JeremyOT JeremyOT

@lauralorenz lauralorenz

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MrFreezeex @k8s-ci-robot @JeremyOT @lauralorenz