Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to run VPA with multiple Pods #7463

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adrianmoisey
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Clarify how the VPA can be run with more than 1 Pod

Which issue(s) this PR fixes:

Fixes # #7450
Also include some words about the issue described in #7461

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adrianmoisey
Once this PR has been reviewed and has the lgtm label, please assign voelzmo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
@adrianmoisey
Copy link
Member Author

cc @raywainman @maxcao13

vertical-pod-autoscaler/FAQ.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
@Shubham82
Copy link
Contributor

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@@ -162,6 +162,16 @@ spec:

and then deploy it manually if your vpa is already configured.

## Can I run the VPA in an HA configuration?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianmoisey, just want to confirm, that Can I run the VPA in an HA configuration? is under the I get recommendations for my single pod replicaSet but they are not applied content if yes then it should be
#### Can I run the VPA in an HA configuration? instead of ## Can I run the VPA in an HA configuration?

If not(which I think) then it should be ### Can I run the VPA in an HA configuration? and you have to mention this under the Contents

Sorry forgot to mention previously.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed in cccebf1

@Shubham82
Copy link
Contributor

@adrianmoisey, just want to confirm, that Can I run the VPA in an HA configuration? is under the I get recommendations for my single pod replicaSet but they are not applied content if yes then it should be #### Can I run the VPA in an HA configuration? instead of ## Can I run the VPA in an HA configuration?

If not(which I think) then it should be ### Can I run the VPA in an HA configuration? and you have to mention this under the Contents

Sorry forgot to mention previously.

/lgtm cancel

removing lgtm as per the above comment,

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
want to run a Deployment with more than one pod, it's recommended to enable a lease
election with the `--leader-elect=true` parameter.

**NOTE: If using GKE, you must set `--leader-elect-resource-name` to something OTHER than "vpa-recommender", for example "vpa-recommender-lease".**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**NOTE: If using GKE, you must set `--leader-elect-resource-name` to something OTHER than "vpa-recommender", for example "vpa-recommender-lease".**
**NOTE:** If using GKE, you must set `--leader-elect-resource-name` to something OTHER than "vpa-recommender", for example "vpa-recommender-lease".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianmoisey, It is the last one, please correct the Note (only the Note should be in bold).
and also squash your all commits into one commit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks.

@Shubham82
Copy link
Contributor

Thanks @adrianmoisey
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants