-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify how to run VPA with multiple Pods #7463
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: adrianmoisey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks |
vertical-pod-autoscaler/FAQ.md
Outdated
@@ -162,6 +162,16 @@ spec: | |||
|
|||
and then deploy it manually if your vpa is already configured. | |||
|
|||
## Can I run the VPA in an HA configuration? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrianmoisey, just want to confirm, that Can I run the VPA in an HA configuration?
is under the I get recommendations for my single pod replicaSet but they are not applied
content if yes then it should be
#### Can I run the VPA in an HA configuration?
instead of ## Can I run the VPA in an HA configuration?
If not(which I think) then it should be ### Can I run the VPA in an HA configuration?
and you have to mention this under the Contents
Sorry forgot to mention previously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed in cccebf1
/lgtm cancel removing |
vertical-pod-autoscaler/FAQ.md
Outdated
want to run a Deployment with more than one pod, it's recommended to enable a lease | ||
election with the `--leader-elect=true` parameter. | ||
|
||
**NOTE: If using GKE, you must set `--leader-elect-resource-name` to something OTHER than "vpa-recommender", for example "vpa-recommender-lease".** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**NOTE: If using GKE, you must set `--leader-elect-resource-name` to something OTHER than "vpa-recommender", for example "vpa-recommender-lease".** | |
**NOTE:** If using GKE, you must set `--leader-elect-resource-name` to something OTHER than "vpa-recommender", for example "vpa-recommender-lease". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrianmoisey, It is the last one, please correct the Note (only the Note should be in bold).
and also squash your all commits into one commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
cccebf1
to
14e9c7b
Compare
Thanks @adrianmoisey |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Clarify how the VPA can be run with more than 1 Pod
Which issue(s) this PR fixes:
Fixes # #7450
Also include some words about the issue described in #7461
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: