Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.27] Add flag to enable fast delete of failed VMSS #7407

Open
wants to merge 1 commit into
base: cluster-autoscaler-release-1.27
Choose a base branch
from

Conversation

willie-yao
Copy link

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

"Refactor" as a part of fork-upstream realignment. Fork introduces an environment variable AZURE_ENABLE_FAST_DELETE_ON_FAILED_PROVISIONING to enable fast delete of failed VMSS, whereas upstream does this by default.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Question: should this be enabled by default to preserve current behavior upstream?

Add flag to enable fast delete of failed VMSS

Enable fast delete for flex
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: willie-yao
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/provider/azure Issues or PRs related to azure provider label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 16, 2024
@willie-yao
Copy link
Author

/hold

This has a behavior change which I'm not sure if we're allowed to backport. Fast delete wasn't a thing in 1.27 so we should probably skip this change?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2024
@willie-yao willie-yao marked this pull request as draft October 16, 2024 18:54
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2024
@Shubham82
Copy link
Contributor

Hi @willie-yao
We only support the last three releases from the latest release, CA v1.31. The supported releases are CA 1.28-1.30.

@Shubham82
Copy link
Contributor

There will be no patch release for CA 1.27 (see #7315), so you can close this PR.

@willie-yao
Copy link
Author

/close

@k8s-ci-robot
Copy link
Contributor

@willie-yao: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@comtalyst
Copy link
Contributor

There will be no patch release for CA 1.27 (see #7315), so you can close this PR.

This is an improvement PR for Azure provider. It supports LTS and has a different release procedure.

@willie-yao
Copy link
Author

/reopen

@k8s-ci-robot
Copy link
Contributor

@willie-yao: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot reopened this Oct 18, 2024
@willie-yao willie-yao marked this pull request as ready for review October 28, 2024 17:57
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants