-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.27] Add flag to enable fast delete of failed VMSS #7407
base: cluster-autoscaler-release-1.27
Are you sure you want to change the base?
[release-1.27] Add flag to enable fast delete of failed VMSS #7407
Conversation
Enable fast delete for flex
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: willie-yao The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold This has a behavior change which I'm not sure if we're allowed to backport. Fast delete wasn't a thing in 1.27 so we should probably skip this change? |
Hi @willie-yao |
There will be no patch release for CA 1.27 (see #7315), so you can close this PR. |
/close |
@willie-yao: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an improvement PR for Azure provider. It supports LTS and has a different release procedure. |
/reopen |
@willie-yao: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
"Refactor" as a part of fork-upstream realignment. Fork introduces an environment variable
AZURE_ENABLE_FAST_DELETE_ON_FAILED_PROVISIONING
to enable fast delete of failed VMSS, whereas upstream does this by default.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Question: should this be enabled by default to preserve current behavior upstream?