-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nil handling in NodeGroupForNode wrapper #7334
Conversation
Signed-off-by: Omer Aplatony <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dbonfigli, omerap12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we should Backport these changes to the supported previous releases so that the bug will be fixed in their upcoming patch release (#7315) If it seems good to you then I will raise PRs for it. |
cc @dbonfigli @omerap12 |
The fix was about an example, so not sure if that is so important. |
@dbonfigli, I thought wrapper.go is part of the externalgrpc cloud provider code, but if it is part of the example there is no need to backport. Thanks for the information. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Improves checking for empty cloudprovider.NodeGroup results. Uses reflect.ValueOf().IsNil() to catch both nil interfaces and interfaces holding nil values.
Which issue(s) this PR fixes:
Fixes #7209
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: