Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cluster-autoscaler-release-1.30] Refactor scale-up to apply resource limits before creating a node group #6931

Open
wants to merge 2 commits into
base: cluster-autoscaler-release-1.30
Choose a base branch
from
Open

[cluster-autoscaler-release-1.30] Refactor scale-up to apply resource limits before creating a node group #6931

wants to merge 2 commits into from

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #6769

/assign yaroslava-serdiuk

NONE

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 17, 2024
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaroslava-serdiuk
Copy link
Contributor

/assign @towca

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2024
@Shubham82
Copy link
Contributor

CC @towca
Need your approval to merge this PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@towca towca

@yaroslava-serdiuk yaroslava-serdiuk

@Shubham82 Shubham82

Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @yaroslava-serdiuk @Shubham82 @towca @aleksandra-malinowska