(spyglass/lenses) allow configuration sandbox permissions #296
Conversation
This provides the ability to configure iframe sandbox permissions pr lense. This allows the operator of the prow installation to define which permissions it trust to each lense. PR comes from the ideas and discussions in kubernetes-sigs#294 Signed-off-by: Roy Sindre Norangshol <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: norrs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
Hi @norrs. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for k8s-prow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| iframe_sandbox_permissions: | ||
| - allow-scripts | ||
| - allow-popups | ||
| - allow-popups-to-escape-sandbox |
There was a problem hiding this comment.
Updated this as it looked like a sane idea to do if this is supposed to demostrate a full configuration file example.
| var defaultSandboxPermissions = strings.Join( | ||
| []string{ | ||
| "allow-scripts", | ||
| "allow-top-navigation", | ||
| "allow-popups", | ||
| "allow-same-origin", | ||
| }, | ||
| " ", | ||
| ) |
There was a problem hiding this comment.
This is defaultSandboxPermissions for the parsedConfig, tho I personally like to work with arrays instead of strings with foo bar zar.
Not sure if you prefer this or the allow-scripts allow-top-navigation allow-popups allow-same-origin instead.
Please let me know, I'll update if you want to change it.
There was a problem hiding this comment.
Suggestion is to do another PR after this to adjust the defaults to not combine allow-same-origin together with allow-scripts, but I suppose this needs to be communicated to the users of the prow installation, so they are aware of the ability to configure this pr lense.
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
Do you need anything more from me on this? |
This provides the ability to configure iframe sandbox permissions pr lense. This allows the operator of the prow installation to define which permissions it trust to each lense.
PR comes from the ideas and discussions in
#294