Only consider host in 'k8s_cluster' when checking if ip is a cached fact #11817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: VannTen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
This avoids spurious failure with 'localhost'. It should also be more correct the inventory contains uncached hosts which are not in `k8s_cluster` and therefore should not be Kubespray business. (We still use hostvars for uncached hosts, because it's easier to select on 'ansible_default_ipv4' that way and does not change the end result)
VannTen
force-pushed
the
fix/scale_yml
branch
from
48b74c2 to
0d55d0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This avoids spurious failure with 'localhost'.
It should also be more correct the inventory contains uncached hosts
which are not in
k8s_clusterand therefore should not be Kubespraybusiness.
(We still use hostvars for uncached hosts, because it's easier to select
on
ansible_default_ipv4that way and does not change the end result)Which issue(s) this PR fixes:
Fixes #11815
Special notes for your reviewer:
Does this PR introduce a user-facing change?: