QEMU RockyLinux 9 and Ubuntu 23.04 #1332
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @feitnomore. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "boot_command_prefix": "c<wait>linux /casper/vmlinuz --- autoinstall ds='nocloud-net;s=http://{{ .HTTPIP }}:{{ .HTTPPort }}/22.04/'<enter><wait>initrd /casper/initrd<enter><wait>boot<enter>", | |||
| "boot_command_prefix": "c<wait>linux /casper/vmlinuz --- autoinstall ds='nocloud-net;s=http://{{ .HTTPIP }}:{{ .HTTPPort }}/22.04/'<enter><wait>initrd /casper/initrd<enter><wait><wait><wait>boot<enter>", | |||
There was a problem hiding this comment.
Is this related to this PR?
There was a problem hiding this comment.
So, while testing, depending on the performance, I've got issues. If you are using a slower system, you may need to wait a bit more. In my case, I needed to add this, as well as increase some timeouts on ansible.cfg so that I could have success. The ansible.cfg changes I have not commited.
| "iso_checksum": "c7cda48494a6d7d9665964388a3fc9c824b3bef0c9ea3818a1be982bc80d346b", | ||
| "iso_checksum_type": "sha256", | ||
| "iso_url": "https://releases.ubuntu.com/23.04/ubuntu-23.04-live-server-amd64.iso", |
There was a problem hiding this comment.
Does this ISO change with new updates to 23.04? If so the checksum will eventually not match, right?
There was a problem hiding this comment.
Unfortunately, I don't see a specific file for 23.04.1 or .2 as we have for 22. The only file I see is this one.
There was a problem hiding this comment.
😞 This is starting to become a recurring issue for us.
@mboersma did we ever come up with any way of handling this when there isn't an old.ubuntu.com link available?
I find it so weird that Ubuntu doesn't produce static images for their current releases.
There was a problem hiding this comment.
https://releases.ubuntu.com/23.04/SHA256SUMS might be a way. A possible solution could be to load the values from that file dynamically.
curl -sS https://releases.ubuntu.com/23.04/SHA256SUMS | grep "ubuntu-23.04-live-server-amd64.iso" | awk '{print $1}'
There was a problem hiding this comment.
I'm more concerned about reproducible builds. If the ubuntu iso is updated with a breaking change it could break for image-builder users without there being any changes / releases to image-builder.
We currently doing have a way around this I don't think, it's just really annoying. 😞
|
I'm not going to block based on the iso issue as we have that elsewhere already. I'll open an issue to address the problem more generally. /lgtm @feitnomore before approval could you please squash the commits? :) |
k8s-ci-robot
added
the
lgtm
Set CPU Model to Host Add QEMU Support for Ubuntu 23.04 LTS Add QEMU Support for RockyLinux 9 Signed-off-by: Marcelo Feitoza Parisi <[email protected]>
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AverageMarcus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR adds RockyLinux 9 as well as Ubuntu 23.04 LTS support for QEMU.
Which issue(s) this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #
Additional context
This PR adds support for Rocky Linux 9.2 and Ubuntu 23.04 LTS for QEMU CAPI.
@AverageMarcus F.Y.I.