Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip preflight check flag #212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aniruddha2000
Copy link
Collaborator

fixes #211

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aniruddha2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 16, 2024
@aniruddha2000
Copy link
Collaborator Author

ServiceAccount conformance-serviceaccount already exist, please run --cleanup first. I am getting this @BenTheElder @rjsadow should we also do the same approach as namespace?

pkg/conformance/deploy.go Outdated Show resolved Hide resolved
@rjsadow
Copy link
Collaborator

rjsadow commented Aug 17, 2024

ServiceAccount conformance-serviceaccount already exist, please run --cleanup first. I am getting this @BenTheElder @rjsadow should we also do the same approach as namespace?

Yes, we'll need to cleanup any namespaced resources.

@aniruddha2000
Copy link
Collaborator Author

@rjsadow i meant as we are reusing the namespace, could we reuse the named resources as well? if we do a cleanup here then there is no point of reusing the namespace because --cleanup also removes the namespace as well I believe.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2024
@aniruddha2000
Copy link
Collaborator Author

@rjsadow i will sqush it later

@rjsadow
Copy link
Collaborator

rjsadow commented Sep 2, 2024

/lgtm
/hold remove when you're ready to merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 2, 2024
Signed-off-by: Aniruddha Basak <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2024
@rjsadow
Copy link
Collaborator

rjsadow commented Oct 24, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag to allow re-using of existing namespace
3 participants