-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add parameters to specify resource tracking configuration #3905
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
929c834
to
8261a45
Compare
8261a45
to
8b34a18
Compare
8b34a18
to
b5df4ba
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue
Description
This PR adds parameters to specify resource tracking prefix.
clusterTagPrefix
, which iselbv2.k8s.aws
, affects cluster resource tagingressTagPrefix
, which isingress.k8s.aws
, affects ingress resource tagserviceTagPrefix
, which isservice.k8s.aws
, affects service resource tagclusterSgRuleLabelPrefix
, which iselbv2.k8s.aws
, affects worker node sg rules labelThis is mainly for internal project that may fork and specify customized values for these prefixes for resources like ALB, NLB, SG, TG, listener, rule; and customize the label of the SG rules we added to the worker node SG (current label is
elbv2.k8s.aws/targetGroupBinding=shared
). The values in the open source are consistent with current behavior, no existing customer behavior change.Added UTs
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯