Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameters to specify resource tracking configuration #3905

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

oliviassss
Copy link
Collaborator

@oliviassss oliviassss commented Oct 18, 2024

Issue

Description

This PR adds parameters to specify resource tracking prefix.

  1. clusterTagPrefix, which is elbv2.k8s.aws, affects cluster resource tag
  2. ingressTagPrefix, which is ingress.k8s.aws, affects ingress resource tag
  3. serviceTagPrefix, which is service.k8s.aws, affects service resource tag
  4. clusterSgRuleLabelPrefix, which is elbv2.k8s.aws, affects worker node sg rules label

This is mainly for internal project that may fork and specify customized values for these prefixes for resources like ALB, NLB, SG, TG, listener, rule; and customize the label of the SG rules we added to the worker node SG (current label is elbv2.k8s.aws/targetGroupBinding=shared). The values in the open source are consistent with current behavior, no existing customer behavior change.

Added UTs

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2024
@oliviassss oliviassss force-pushed the tag-prefix-flag branch 2 times, most recently from 929c834 to 8261a45 Compare October 24, 2024 20:31
@oliviassss oliviassss changed the title [WIP]add flag to specify resource prefix for resource tags add flag to specify resource prefix for resource tags Oct 24, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 30, 2024
@oliviassss oliviassss changed the title add flag to specify resource prefix for resource tags add flag to specify resource tracking configuration Oct 30, 2024
@oliviassss oliviassss changed the title add flag to specify resource tracking configuration add parameters to specify resource tracking configuration Nov 14, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants