Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase and fixes for https://github.com/kubernetes-client/python/pull/2147 #2255

Closed
wants to merge 7 commits into from
Closed

Rebase and fixes for https://github.com/kubernetes-client/python/pull/2147 #2255

wants to merge 7 commits into from

Conversation

PhroZenOne
Copy link

I just took the branch from #2147 and rebased it, I also fixed the client patch but I am unsure about its usage.

I also ran the scripts/update-client.sh to update the source files that are autogenerated.

@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 22, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 22, 2024 •
edited
Loading

CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @PhroZenOne!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PhroZenOne
Once this PR has been reviewed and has the lgtm label, please assign yliaog for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PhroZenOne PhroZenOne mentioned this pull request Jul 22, 2024
Open
@PhroZenOne PhroZenOne force-pushed the feat/add-proxy-support branch from f076191 to 037e78e Compare July 22, 2024 09:19
@PhroZenOne
Use openapi 7.2.0 for socks support
1f95e8b 
This is needed for the proxy client to generate socks support
@PhroZenOne
Updated rest client patch
04a4fb6 
I'm unsure about the function of this patch but I tried to keep the logic
the same as the previous behavior. Just adjusting it so it applies to
the new source
@PhroZenOne
Updated setup.py to use kubernetes.client.api
6581f42 
Previously it used kubernetes.client.apis and it was deprecated in favor of api
@PhroZenOne
Generated sources.
9638aab 
This commit contains the changes applied by running scripts/update-client.sh

No manual changes, only auto generated code
@PhroZenOne PhroZenOne force-pushed the feat/add-proxy-support branch from 037e78e to 9638aab Compare July 22, 2024 11:51
@PhroZenOne
Copy link
Author

PhroZenOne commented Jul 22, 2024 •
edited
Loading

Closing as this needs a lot more work as the API has changed. See comment on #2147

@PhroZenOne PhroZenOne closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf Awaiting requested review from fabianvf

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhroZenOne @k8s-ci-robot @rolf-moz