Added s390x and ppc64le support #10766

R3hankhan123 · 2024-04-30T14:45:45Z

Description of your changes:
Added multiarch support for s390x and ppc64le by adding Architectural parameters wherever possible in dockerfiles and bash scripts
Checklist:

The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

google-oss-prow · 2024-04-30T14:45:56Z

Hi @R3hankhan123. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hbelmiro · 2024-04-30T17:31:39Z

/ok-to-test

hbelmiro

/retest

hbelmiro · 2024-04-30T17:38:05Z

/retest

google-oss-prow · 2024-05-01T12:51:33Z

New changes are detected. LGTM label has been removed.

R3hankhan123 · 2024-05-02T05:21:03Z

@hbelmiro @chensun are the test failing because Kubernetes 1.25 is no longer supported?

rimolive · 2024-05-04T15:16:15Z

@R3hankhan123 We have an known issue with the current e2e tests so for now we'll need to run them locally to ensure the PR does not introduce any breaking changes.

hbelmiro · 2024-07-25T11:59:37Z

@R3hankhan123 the e2e test was migrated to GitHub Actions and is working now. Can you please rebase?

/reopen

google-oss-prow · 2024-07-25T11:59:41Z

@hbelmiro: Reopened this PR.

In response to this:

@R3hankhan123 the e2e test was migrated to GitHub Actions and is working now. Can you please rebase?

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

dilipgb · 2024-07-26T05:48:24Z

/reopen

google-oss-prow · 2024-07-26T05:48:27Z

@dilipgb: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

R3hankhan123 · 2024-07-26T05:49:34Z

/reopen

google-oss-prow · 2024-07-26T05:49:38Z

@R3hankhan123: Failed to re-open PR: state cannot be changed. There are no new commits on the R3hankhan123:s390x branch.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Rehan Khan <[email protected]>

R3hankhan123 · 2024-09-20T12:06:15Z

/reopen

google-oss-prow · 2024-09-20T12:06:20Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

backend/OWNERS
third_party/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow · 2024-09-20T12:06:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chensun for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

backend/OWNERS
third_party/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

R3hankhan123 · 2024-09-20T12:09:50Z

@hbelmiro looks like the workflows still arent being triggered automatically

Signed-off-by: Rehan Khan <[email protected]>

hbelmiro · 2024-09-23T15:16:14Z

/ok-to-test
/rerun-all

R3hankhan123 · 2024-09-23T15:40:05Z

@hbelmiro looks like all the tests have passed and just needs the lgtm label

backend/Dockerfile.launcher

backend/Makefile

backend/api/Dockerfile

hbelmiro · 2024-09-23T15:56:58Z

backend/src/cache/deployer/Dockerfile

@@ -1,11 +1,17 @@
-FROM gcr.io/google.com/cloudsdktool/google-cloud-cli:alpine
+FROM alpine


I'm not sure about this.
@rimolive @chensun thoughts?

@hbelmiro gcr.io/google.com/cloudsdktool/google-cloud-cli:alpine image is not supporting multiple architecture. It only amd/arm architectures.

Since gcloud component installed is only kubectl (https://github.com/kubeflow/pipelines/blob/master/backend/src/cache/deployer/Dockerfile#L8) we are taking plain vanila alpine and installing all the needed packages including kubectl from binary distributions as you see in below code snippet.

@dilipgb I see. But I'm not sure how able we are to change images without a broader involvement of the community. Like asking in the community call, for example.

cc @HumairAK

backend/src/cache/deployer/deploy-cache-service.sh

third_party/minio/Dockerfile

Signed-off-by: Rehan Khan <[email protected]>

hbelmiro · 2024-09-24T15:02:26Z

/ok-to-test
/rerun-all

dilipgb · 2024-10-03T11:24:04Z

@hbelmiro can we list this as one of the topic to discuss in coming community meeting?

hbelmiro · 2024-10-03T14:58:05Z

@hbelmiro can we list this as one of the topic to discuss in coming community meeting?

@R3hankhan123 Sure.

HumairAK · 2024-10-09T13:33:54Z

third_party/minio/Dockerfile

@@ -23,7 +23,7 @@ RUN sh /third_party/download_source.sh </third_party/minio/repo-MPL.txt


 # Minio image
-FROM minio/minio:RELEASE.2019-08-14T20-37-41Z
+FROM minio/minio:RELEASE.2020-12-18T03-27-42Z


is this required for this PR?

@HumairAK the image used here is published few years back. We enabled the s390x and ppc64le builds later after this image being build. Hence we are requesting to update this. You can see from tag, the image used is released in 2019 and we are having image supported from 2020.

HumairAK · 2024-10-09T19:18:16Z

backend/Makefile

@@ -66,25 +67,25 @@ image_all: image_apiserver image_persistence_agent image_cache image_swf image_v

 .PHONY: image_apiserver
 image_apiserver:
-	cd $(MOD_ROOT) && ${CONTAINER_ENGINE} build -t ${IMG_TAG_APISERVER} -f backend/Dockerfile .
+	cd $(MOD_ROOT) && ${CONTAINER_ENGINE} buildx build --platform $(PLATFORMS) -t ${IMG_TAG_APISERVER} -f backend/Dockerfile .


so I think this should require a KFP community call topic & consideration

this looks to me like it's essentially increasing the support level of KFP to now support all of these architectures, and we should understand what the overhead of this is

cc @chensun / @zijianjoy do you have any thoughts here?

HumairAK · 2024-10-09T19:19:18Z

/hold due to: #10766 (comment)

R3hankhan123 · 2024-10-21T05:05:03Z

Hi @HumairAK , can you add multi arch discussion in the doc for the upcoming community meet

anishasthana · 2024-11-20T18:17:45Z

backend/Makefile

@@ -4,6 +4,7 @@ CSV_PATH=backend/third_party_licenses

 # Container Build Params
 CONTAINER_ENGINE ?= docker
+PLATFORMS ?= linux/amd64,linux/s390x,linux/ppc64le


Suggested change

PLATFORMS ?= linux/amd64,linux/s390x,linux/ppc64le

PLATFORMS ?= linux/amd64

Can we remove s390x and ppc64le from this PR? So this PR is focused on just enabling the ability to build other architectures with minimal effort. We can revisit the "build new architectures by default" topic in future. @HumairAK @gregsheremeta thoughts?

@anishasthana we can have another rule to build multiarch build and add build platform there for cross platform builds and we can use current rule for native build (This is something other communities like contour uses for multiarch builds). code may looks something like this.

# Platforms to build the multi-arch image for. IMAGE_PLATFORMS ?= linux/amd64,linux/s390x,linux/ppc64le multiarch-build: @mkdir -p $(shell pwd)/image docker buildx build $(IMAGE_RESULT_FLAG) \ --platform $(IMAGE_PLATFORMS) \ --build-arg "BUILD_GOPRIVATE=$(BUILD_GOPRIVATE)" \ --build-arg "BUILD_GOPROXY=$(BUILD_GOPROXY)" \ --build-arg "BUILD_GOSUMDB=$(BUILD_GOSUMDB)" \ --build-arg "BUILD_BASE_IMAGE=$(BUILD_BASE_IMAGE)" \ --build-arg "BUILD_VERSION=$(BUILD_VERSION)" \ --build-arg "BUILD_BRANCH=$(BUILD_BRANCH)" \ --build-arg "BUILD_SHA=$(BUILD_SHA)" \ --build-arg "BUILD_CGO_ENABLED=$(BUILD_CGO_ENABLED)" \ --build-arg "BUILD_EXTRA_GO_LDFLAGS=$(BUILD_EXTRA_GO_LDFLAGS)" \ --build-arg "BUILD_GOEXPERIMENT=$(BUILD_GOEXPERIMENT)" \ $(DOCKER_BUILD_LABELS) \ $(IMAGE_TAGS) \ $(shell pwd) build: docker build \ --build-arg "BUILD_GOPRIVATE=$(BUILD_GOPRIVATE)" \ --build-arg "BUILD_GOPROXY=$(BUILD_GOPROXY)" \ --build-arg "BUILD_GOSUMDB=$(BUILD_GOSUMDB)" \ --build-arg "BUILD_BASE_IMAGE=$(BUILD_BASE_IMAGE)" \ --build-arg "BUILD_VERSION=$(BUILD_VERSION)" \ --build-arg "BUILD_BRANCH=$(BUILD_BRANCH)" \ --build-arg "BUILD_SHA=$(BUILD_SHA)" \ --build-arg "BUILD_CGO_ENABLED=$(BUILD_CGO_ENABLED)" \ --build-arg "BUILD_EXTRA_GO_LDFLAGS=$(BUILD_EXTRA_GO_LDFLAGS)" \ --build-arg "BUILD_GOEXPERIMENT=$(BUILD_GOEXPERIMENT)" \ $(DOCKER_BUILD_LABELS) \ $(shell pwd) \ --tag $(IMAGE):$(VERSION)

So primary architecture which is x86/native platform here don't have build the multiarch image for every time.

google-oss-prow bot requested review from chensun and zijianjoy April 30, 2024 14:45

google-oss-prow bot added size/M needs-ok-to-test labels Apr 30, 2024

google-oss-prow bot added ok-to-test and removed needs-ok-to-test labels Apr 30, 2024

hbelmiro reviewed Apr 30, 2024

View reviewed changes

google-oss-prow bot assigned hbelmiro Apr 30, 2024

google-oss-prow bot added the lgtm label Apr 30, 2024

google-oss-prow bot removed the lgtm label May 1, 2024

R3hankhan123 requested a review from hbelmiro May 2, 2024 05:41

github-actions bot added the Stale label Jul 4, 2024

github-actions bot closed this Jul 25, 2024

google-oss-prow bot reopened this Jul 25, 2024

R3hankhan123 closed this Jul 26, 2024

R3hankhan123 force-pushed the s390x branch from 0b5e3a3 to f6ea7e3 Compare July 26, 2024 05:36

google-oss-prow bot added size/XS and removed size/M labels Jul 26, 2024

google-oss-prow bot added the size/XXL label Sep 20, 2024

R3hankhan123 closed this Sep 20, 2024

R3hankhan123 force-pushed the s390x branch from 77fd619 to ba006bd Compare September 20, 2024 06:29

google-oss-prow bot added size/XS and removed size/XXL labels Sep 20, 2024

Added s390x and ppc64le support after rebasing

a6b6951

Signed-off-by: Rehan Khan <[email protected]>

R3hankhan123 reopened this Sep 20, 2024

google-oss-prow bot added size/M and removed size/XS labels Sep 20, 2024

R3hankhan123 force-pushed the s390x branch from d2b0454 to a6b6951 Compare September 23, 2024 05:10

Fixed argo installation in Dockerfile

5d47c2e

Signed-off-by: Rehan Khan <[email protected]>

hbelmiro reviewed Sep 23, 2024

View reviewed changes

Made the requested changes

b573e98

Signed-off-by: Rehan Khan <[email protected]>

hbelmiro mentioned this pull request Sep 27, 2024

chore: adding @hbelmiro to backend reviewers #11256

Merged

2 tasks

HumairAK reviewed Oct 9, 2024

View reviewed changes

google-oss-prow bot added the do-not-merge/hold label Oct 9, 2024

anishasthana reviewed Nov 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added s390x and ppc64le support #10766

Added s390x and ppc64le support #10766

R3hankhan123 commented Apr 30, 2024

google-oss-prow bot commented Apr 30, 2024

hbelmiro commented Apr 30, 2024

hbelmiro left a comment •

edited

Loading

hbelmiro commented Apr 30, 2024

google-oss-prow bot commented May 1, 2024

R3hankhan123 commented May 2, 2024 •

edited

Loading

rimolive commented May 4, 2024

hbelmiro commented Jul 25, 2024

google-oss-prow bot commented Jul 25, 2024

dilipgb commented Jul 26, 2024

google-oss-prow bot commented Jul 26, 2024

R3hankhan123 commented Jul 26, 2024

google-oss-prow bot commented Jul 26, 2024

R3hankhan123 commented Sep 20, 2024

google-oss-prow bot commented Sep 20, 2024

google-oss-prow bot commented Sep 20, 2024

R3hankhan123 commented Sep 20, 2024

hbelmiro commented Sep 23, 2024

R3hankhan123 commented Sep 23, 2024

hbelmiro Sep 23, 2024

dilipgb Sep 24, 2024 •

edited

Loading

hbelmiro Sep 27, 2024

hbelmiro commented Sep 24, 2024

dilipgb commented Oct 3, 2024

hbelmiro commented Oct 3, 2024

HumairAK Oct 9, 2024

dilipgb Oct 9, 2024

HumairAK Oct 9, 2024 •

edited

Loading

HumairAK commented Oct 9, 2024

R3hankhan123 commented Oct 21, 2024

anishasthana Nov 20, 2024

dilipgb Nov 20, 2024 •

edited

Loading

		@@ -1,11 +1,17 @@
		FROM gcr.io/google.com/cloudsdktool/google-cloud-cli:alpine
		FROM alpine

	PLATFORMS ?= linux/amd64,linux/s390x,linux/ppc64le
	PLATFORMS ?= linux/amd64

Added s390x and ppc64le support #10766

Are you sure you want to change the base?

Added s390x and ppc64le support #10766

Conversation

R3hankhan123 commented Apr 30, 2024

google-oss-prow bot commented Apr 30, 2024

hbelmiro commented Apr 30, 2024

hbelmiro left a comment • edited Loading

Choose a reason for hiding this comment

hbelmiro commented Apr 30, 2024

google-oss-prow bot commented May 1, 2024

R3hankhan123 commented May 2, 2024 • edited Loading

rimolive commented May 4, 2024

hbelmiro commented Jul 25, 2024

google-oss-prow bot commented Jul 25, 2024

dilipgb commented Jul 26, 2024

google-oss-prow bot commented Jul 26, 2024

R3hankhan123 commented Jul 26, 2024

google-oss-prow bot commented Jul 26, 2024

R3hankhan123 commented Sep 20, 2024

google-oss-prow bot commented Sep 20, 2024

google-oss-prow bot commented Sep 20, 2024

R3hankhan123 commented Sep 20, 2024

hbelmiro commented Sep 23, 2024

R3hankhan123 commented Sep 23, 2024

hbelmiro Sep 23, 2024

Choose a reason for hiding this comment

dilipgb Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

hbelmiro Sep 27, 2024

Choose a reason for hiding this comment

hbelmiro commented Sep 24, 2024

dilipgb commented Oct 3, 2024

hbelmiro commented Oct 3, 2024

HumairAK Oct 9, 2024

Choose a reason for hiding this comment

dilipgb Oct 9, 2024

Choose a reason for hiding this comment

HumairAK Oct 9, 2024 • edited Loading

Choose a reason for hiding this comment

HumairAK commented Oct 9, 2024

R3hankhan123 commented Oct 21, 2024

anishasthana Nov 20, 2024

Choose a reason for hiding this comment

dilipgb Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

hbelmiro left a comment •

edited

Loading

R3hankhan123 commented May 2, 2024 •

edited

Loading

dilipgb Sep 24, 2024 •

edited

Loading

HumairAK Oct 9, 2024 •

edited

Loading

dilipgb Nov 20, 2024 •

edited

Loading