Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new release team member - Tester #708

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

tombuuz
Copy link
Contributor

@tombuuz tombuuz commented Sep 16, 2024

Joining a tester to the Kubeflow release team
([email protected])

Copy link

Hi @tombuuz. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@terrytangyuan
Copy link
Member

/cc @rimolive

@rimolive
Copy link
Member

According to devstats.io, @tombuuz made at least 2 contributions to Kubeflow. That said, he should be eligible to become a member.

Also, since he volunteered to be part of the 1.10 Release Team, I believe he can make more contributions to the community. I'm good to have him added to the GitHub org.

@tombuuz Can you add in the PR description the contributions you made?

@andreyvelich
Copy link
Member

I think, before updating the release team, we should establish the 1.10 release team with release managers and liaisons.
Also, you can't update the GitHub teams with users who are not member of Kubeflow GitHub org.

@rimolive
Copy link
Member

rimolive commented Nov 5, 2024

@andreyvelich @terrytangyuan Release Team is formed. Can you please approve his membership?

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor Author

@tombuuz tombuuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add the github username to join the Release team

@google-oss-prow google-oss-prow bot removed the lgtm label Nov 5, 2024
Signed-off-by: Dagvanorov Lkhagvajav <[email protected]>
Signed-off-by: tombuuz <[email protected]>
@rimolive
Copy link
Member

rimolive commented Nov 6, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 6, 2024
@google-oss-prow google-oss-prow bot merged commit e9166c7 into kubeflow:master Nov 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants