-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A new release team member - Tester #708
Conversation
Hi @tombuuz. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @rimolive |
According to devstats.io, @tombuuz made at least 2 contributions to Kubeflow. That said, he should be eligible to become a member. Also, since he volunteered to be part of the 1.10 Release Team, I believe he can make more contributions to the community. I'm good to have him added to the GitHub org. @tombuuz Can you add in the PR description the contributions you made? |
I think, before updating the release team, we should establish the 1.10 release team with release managers and liaisons. |
@andreyvelich @terrytangyuan Release Team is formed. Can you please approve his membership? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add the github username to join the Release team
Signed-off-by: Dagvanorov Lkhagvajav <[email protected]> Signed-off-by: tombuuz <[email protected]>
Signed-off-by: tombuuz <[email protected]>
/lgtm |
Joining a tester to the Kubeflow release team
([email protected])