Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update provider #2

Merged
merged 4 commits into from
Dec 13, 2023
Merged

Update provider #2

merged 4 commits into from
Dec 13, 2023

Conversation

sheikh-arman
Copy link
Contributor

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@sheikh-arman sheikh-arman marked this pull request as ready for review December 11, 2023 08:47
examples/provider-config.yaml Outdated Show resolved Hide resolved
namespace: crossplane-system
name: gcp-secret
key: creds
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add newline

examples/redis/provision-redis-instance.yaml Outdated Show resolved Hide resolved
host: 10.20.30.40
port: 3306
region: us-central1
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add newline

examples/sql/provision-sql-database.yaml Outdated Show resolved Hide resolved
internal/features/features.go Show resolved Hide resolved
Signed-off-by: SK Ali Arman <[email protected]>
Copy link
Contributor

@Superm4n97 Superm4n97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamalsaha tamalsaha merged commit 2664295 into main Dec 13, 2023
7 of 8 checks passed
@tamalsaha tamalsaha deleted the gcpdb branch December 13, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants