feat: (recommend) Implement recommend functionality for Docker Client #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
use a common interface to support other clients as well
also create common Object{} to support different k8s obejcts such as Deployment, Daemonset etc
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
…rs as well Signed-off-by: tesla59 <[email protected]>
this removes dependency of recommend command on kubearmor Signed-off-by: tesla59 <[email protected]>
|
@daemon1024 please review |
|
Can you include screenshots of how it's working? |
|
Case 1: systemd mode
Case 2: k8s mode There is an error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing K8s client directly to recommend.Recommend(), use an interface to pass K8s Client. This way we can pass both K8s Client and Docker Client