-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check for update in any mandatory release of karmor CLI #251
base: main
Are you sure you want to change the base?
Added check for update in any mandatory release of karmor CLI #251
Conversation
67b6487
to
e448345
Compare
Hey @TheRealSibasishBehera . Great work on this 🚀. |
the first stdout For this feature to identify major updates , the release notes must have a keyword On further releases we can add the If its alright i can add a unit test with a mock |
@TheRealSibasishBehera i don't think a test would be necessary for this feature. As long as the keyword isn't case sensitive. If it is case sensitive, could you make it "MANDATORY" all caps? |
@PrimalPimmy I have updated the code , please take a look |
30f27f4
to
0a120ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an incorrect PR. This PR implements the logic in its own binary. The aim of the task was to check whether a mandatory release exists in the github when someone calls karmor version
and highlight that a mandatory upgrade is pending.
Signed-off-by: Sibasish Behera <[email protected]>
0a120ca
to
9eb3110
Compare
Signed-off-by: Sibasish Behera <[email protected]>
Signed-off-by: sibashi [email protected]
Fixes #249
the function checkForUpdates first finds the latest release that contains the keyword "mandatory" in its release notes
compared it with current version from
selfupdate.GitSummary
If diffrent informs the user