fix(logs): reset eventChan everytime KarmorLogStart() is called
#1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aryan-sharma11
force-pushed
the
reset-karmorlog-evenChan
branch
2 times, most recently
from
b8c865f
to
7ccccaa
Compare
Aryan-sharma11
approved these changes
Jul 11, 2024
Prateeknandle
approved these changes
Jul 11, 2024
This will reduce flakiness in the tests Signed-off-by: Navin Chandra <[email protected]>
Prateeknandle
force-pushed
the
reset-karmorlog-evenChan
branch
from
7ccccaa
to
74e9772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Draining the
eventChanin everyKarmorLogStart()function call will reduce flakiness in the tests.Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>