fix(helm): quote configmap values #1795
Merged
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
api documentation verifies the field in the data section is map[string]string |
|
Hey @daemon1024 can u please review this |
daemon1024
requested review from
Prateeknandle,
DelusionalOptimist and
rksharma95
Prateeknandle
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
LGTM 👍🏼
@tesla59 thanks for reporting the issue and also handling it.
|
@tesla59 can you rebase the branch as we have fixed the CI recently |
Signed-off-by: tesla59 <[email protected]>
tesla59
force-pushed
the
tesla/helm-value-fix
branch
from
be0ce85
to
4015420
Compare
|
@Aryan-sharma11 done |
kranurag7
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #1794
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Tested using
helm upgrade --install kubearmor ./deployments/helm/KubeArmor -n kubearmor --create-namespaceAdditional information for reviewer? :
No
Checklist:
<type>(<scope>): <subject>