Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): handle bpf as an exception for setting node annotations #1786

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(core): handle bpf as an exception for setting node annotations #1786

wants to merge 2 commits into from

Conversation

tesla59
Copy link
Contributor

@tesla59 tesla59 commented Jun 21, 2024

Purpose of PR?:

Fixes #1765

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::
In progress (draft PR)

Additional information for reviewer? :
No

Checklist:

  • Bug fix. Fixes Host Security Policy not enforced #1765
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@DelusionalOptimist DelusionalOptimist marked this pull request as ready for review July 23, 2024 07:56
@tesla59
Copy link
Contributor Author

tesla59 commented Jul 23, 2024

@DelusionalOptimist i have updated the logic to check for annotation. its ready to review
also rebased to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DelusionalOptimist DelusionalOptimist DelusionalOptimist left review comments

@rksharma95 rksharma95 Awaiting requested review from rksharma95

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Host Security Policy not enforced
2 participants
@tesla59 @DelusionalOptimist