Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): coverage report generation for k8s_env tests #1759

Closed
wants to merge 1 commit into from

Conversation

tesla59
Copy link
Contributor

@tesla59 tesla59 commented May 20, 2024

Purpose of PR?:

Fixes #1758

Does this PR introduce a breaking change?
No, it changes Ci step

If the changes in this PR are manually verified, list down the scenarios covered::
N/A

Additional information for reviewer? :
The main purpose of gover is to concatenate multiple cover profiles into a single file. We dont need to do this as ginkgo already stored the cover profile in a single file (by default coverprofile.out).

The PR adds a flag in ginkgo test command to generate test profile for every package in the github.com/kubearmor/KubeArmor/tests . The reason to use full path is a bug in ginkgo when using relative path. It is supposedly fixed but using the relative path didnt work in our case (ref: onsi/ginkgo#1161 (comment))

Checklist:

  • Bug fix. Fixes CI test suite does not generate coverage report #1758
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

@tesla59
Copy link
Contributor Author

tesla59 commented May 20, 2024

Hi @DelusionalOptimist
Can u please review this
If approved, this can be extended to systemd test as well

@tesla59
Copy link
Contributor Author

tesla59 commented May 22, 2024

might fix #845

@tesla59 tesla59 closed this Aug 7, 2024
@tesla59 tesla59 deleted the tesla/fix-coverage branch August 7, 2024 10:22
@tesla59 tesla59 restored the tesla/fix-coverage branch August 7, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI test suite does not generate coverage report
1 participant