Vgoncharova/mvc #184
Vgoncharova/mvc #184
Conversation
… that uses FreeMarker templates and Exposed
… that uses FreeMarker templates and Exposed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Hey @VGoncharova, good job!
Could you please address the comments?
@vnikolova, please also take a look
mvc-web/build.gradle.kts
Outdated
| implementation("org.jetbrains.exposed:exposed-core:$exposed_version") | ||
| implementation("org.jetbrains.exposed:exposed-dao:$exposed_version") | ||
| implementation("org.jetbrains.exposed:exposed-jdbc:$exposed_version") | ||
| implementation("com.h2database:h2:2.1.214") |
There was a problem hiding this comment.
Could you please extract the version in the properties file?
|
|
||
| object DatabaseFactory { | ||
| fun init() { | ||
| val driverClassName = "org.h2.Driver" |
There was a problem hiding this comment.
Please move the DB configuration keys to the application.yaml or application.properties
mvc-web/README.md
Outdated
| ./gradlew run | ||
| ``` | ||
|
|
||
| Then, navigate to [http://localhost:8080/](http://localhost:8080/) to see the sample home page.localhost:8080/](http://localhost:8080/) in a browser to create, edit, and delete articles. |
There was a problem hiding this comment.
There's nothing at http://localhost:8080/. This line should say:
"Then, navigate to the following pages:
- http://localhost:8080/wish/list to view and modify the wishlist.
- http://localhost:8080/wish/topwishes to see the top three wishes in the list."
| import org.jetbrains.exposed.sql.transactions.experimental.newSuspendedTransaction | ||
| import org.jetbrains.exposed.sql.transactions.transaction | ||
|
|
||
| object DatabaseFactory { |
There was a problem hiding this comment.
In other examples, we renamed "DatabaseFactory" to "DatabaseSingleton". I think we should keep the names consistent.
mvc-web/README.md
Outdated
| @@ -0,0 +1,13 @@ | |||
| # MVC application for Ktor | |||
There was a problem hiding this comment.
"MVC application with Ktor Server"
| application { | ||
| configureRouting() | ||
| } | ||
| client.get("/").apply { |
There was a problem hiding this comment.
This test would fail. Can we either remove it or add another valid test?
…to the application.yaml , changed routes and project description at README.md , DatabaseFactory renamed to DatabaseSingleton for consistency
Wishlist application for adding and removing wishes to Wishlist that uses FreeMarker templates and Exposed